Issue 2969343002: Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2969343002: Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren(). (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren(). We still visit them, but analyzer and analysis_server don't need it. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ce43a15e518b3d748081df063c8e820458838764

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -31 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_method.dart	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/inline_method.dart	View	2 chunks	+7 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/test/abstract_single_unit.dart	View	3 chunks	+28 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/name_suggestion_test.dart	View	5 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 5 months ago (2017-07-05 19:28:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ce43a15e518b3d748081df063c8e820458838764 (presubmit successful).