Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().

pkg/analysis_server/test/services/correction/name_suggestion_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/src/services/correction/name_suggestion.dart';
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../../abstract_single_unit.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(VariableNameSuggestionTest);
   });
@@ skipping 15 matching lines @@
   }
 
   test_forExpression_expectedType() async {
     await resolveTestUnit('''
 class TreeNode {}
 main() {
   TreeNode node = null;
 }
 ''');
     Set<String> excluded = new Set<String>.from([]);
-    DartType expectedType = (findElement('node') as LocalVariableElement).type;
+    DartType expectedType = findLocalVariable('node').type;
     Expression assignedExpression =
         findNodeAtString('null;', (node) => node is NullLiteral);
     List<String> suggestions = getVariableNameSuggestionsForExpression(
         expectedType, assignedExpression, excluded);
     expect(suggestions, unorderedEquals(['treeNode', 'node']));
   }
 
   test_forExpression_expectedType_double() async {
     await resolveTestUnit('''
 main() {
   double res = 0.0;
 }
 ''');
-    DartType expectedType = (findElement('res') as LocalVariableElement).type;
+    DartType expectedType = findLocalVariable('res').type;
     Expression assignedExpression = findNodeAtString('0.0;');
     // first choice for "double" is "d"
     expect(
         getVariableNameSuggestionsForExpression(
             expectedType, assignedExpression, new Set.from([])),
         unorderedEquals(['d']));
     // if "d" is used, try "e", "f", etc
     expect(
         getVariableNameSuggestionsForExpression(
             expectedType, assignedExpression, new Set.from(['d', 'e'])),
         unorderedEquals(['f']));
   }
 
   test_forExpression_expectedType_int() async {
     await resolveTestUnit('''
 main() {
   int res = 0;
 }
 ''');
-    DartType expectedType = (findElement('res') as LocalVariableElement).type;
+    DartType expectedType = findLocalVariable('res').type;
     Expression assignedExpression = findNodeAtString('0;');
     // first choice for "int" is "i"
     expect(
         getVariableNameSuggestionsForExpression(
             expectedType, assignedExpression, new Set.from([])),
         unorderedEquals(['i']));
     // if "i" is used, try "j", "k", etc
     expect(
         getVariableNameSuggestionsForExpression(
             expectedType, assignedExpression, new Set.from(['i', 'j'])),
         unorderedEquals(['k']));
   }
 
   test_forExpression_expectedType_String() async {
     await resolveTestUnit('''
 main() {
   String res = 'abc';
 }
 ''');
-    DartType expectedType = (findElement('res') as LocalVariableElement).type;
+    DartType expectedType = findLocalVariable('res').type;
     Expression assignedExpression = findNodeAtString("'abc';");
     // first choice for "String" is "s"
     expect(
         getVariableNameSuggestionsForExpression(
             expectedType, assignedExpression, new Set.from([])),
         unorderedEquals(['s']));
   }
 
   test_forExpression_instanceCreation() async {
     verifyNoTestUnitErrors = false;
@@ skipping 220 matching lines @@
     }
     {
       Set<String> excluded = new Set<String>.from(['world']);
       List<String> suggestions =
           getVariableNameSuggestionsForText('Goodbye, cruel world!', excluded);
       expect(suggestions,
           unorderedEquals(['goodbyeCruelWorld', 'cruelWorld', 'world2']));
     }
   }
 }