Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().

pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element;
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/correction/strings.dart';
 import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';
-import 'package:analysis_server/src/services/search/element_visitors.dart';
 import 'package:analysis_server/src/services/search/hierarchy.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
 import 'package:analyzer/src/dart/element/ast_provider.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
@@ skipping 124 matching lines @@
 
 /**
  * Returns the names which will shadow or will be shadowed by any declaration
  * at [node].
  */
 Set<String> _getNamesConflictingAt(AstNode node) {
   Set<String> result = new Set<String>();
   // local variables and functions
   {
     SourceRange localsRange = _getLocalsConflictingRange(node);
-    ExecutableElement enclosingExecutable = getEnclosingExecutableElement(node);
-    if (enclosingExecutable != null) {
-      visitChildren(enclosingExecutable, (element) {
-        if (element is LocalElement) {
-          SourceRange elementRange = element.visibleRange;
-          if (elementRange != null && elementRange.intersects(localsRange)) {
-            result.add(element.displayName);
-          }
-        }
-        return true;
-      });
+    AstNode enclosingExecutable = getEnclosingExecutableNode(node);
+    List<LocalElement> elements = getDefinedLocalElements(enclosingExecutable);
+    for (LocalElement element in elements) {
+      SourceRange elementRange = element.visibleRange;
+      if (elementRange != null && elementRange.intersects(localsRange)) {
+        result.add(element.displayName);
+      }
     }
   }
   // fields
   {
     ClassElement enclosingClassElement = getEnclosingClassElement(node);
     if (enclosingClassElement != null) {
       Set<ClassElement> elements = new Set<ClassElement>();
       elements.add(enclosingClassElement);
       elements.addAll(getSuperClasses(enclosingClassElement));
       for (ClassElement classElement in elements) {
@@ skipping 697 matching lines @@
   }
 
   void _addVariable(SimpleIdentifier node) {
     VariableElement variableElement = getLocalVariableElement(node);
     if (variableElement != null) {
       SourceRange nodeRange = range.node(node);
       result.addVariable(variableElement, nodeRange);
     }
   }
 }