Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2969023002: Update the comments on PasswordSpecificsData. The Android format was described wrong. (Closed)

Created:
3 years, 5 months ago by vasilii
Modified:
3 years, 5 months ago
Reviewers:
engedy, pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the comments on PasswordSpecificsData. The Android format was described wrong. BUG=739101 Review-Url: https://codereview.chromium.org/2969023002 Cr-Commit-Position: refs/heads/master@{#484520} Committed: https://chromium.googlesource.com/chromium/src/+/4d5d6474d72a5b7bd95f76da0acd40cf2f9d92db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/sync/protocol/password_specifics.proto View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vasilii
Hi, please review
3 years, 5 months ago (2017-07-04 08:50:37 UTC) #2
engedy
LGTM, thanks for fixing this!
3 years, 5 months ago (2017-07-04 17:47:11 UTC) #3
vasilii
Hi Pavel, please review
3 years, 5 months ago (2017-07-05 07:54:57 UTC) #5
pavely
lgtm
3 years, 5 months ago (2017-07-05 17:58:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969023002/1
3 years, 5 months ago (2017-07-06 08:42:12 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 09:52:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d5d6474d72a5b7bd95f76da0acd...

Powered by Google App Engine
This is Rietveld 408576698