Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Side by Side Diff: components/sync/protocol/password_specifics.proto

Issue 2969023002: Update the comments on PasswordSpecificsData. The Android format was described wrong. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for password data. 5 // Sync protocol datatype extension for password data.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 24 matching lines...) Expand all
35 // android credential or a password saved through Credential Manager API 35 // android credential or a password saved through Credential Manager API
36 // (https://w3c.github.io/webappsec/specs/credentialmanagement/). 36 // (https://w3c.github.io/webappsec/specs/credentialmanagement/).
37 // SCHEME_BASIC(1), basic access http authentication. 37 // SCHEME_BASIC(1), basic access http authentication.
38 // SCHEME_DIGEST(2), digest access authentication. 38 // SCHEME_DIGEST(2), digest access authentication.
39 // SCHEME_OTHER(3), another access authentication. 39 // SCHEME_OTHER(3), another access authentication.
40 optional int32 scheme = 1; 40 optional int32 scheme = 1;
41 41
42 // For parsed web forms and normal passwords saved through Credential Manager 42 // For parsed web forms and normal passwords saved through Credential Manager
43 // API: url-scheme://url-host[:url-port]/ 43 // API: url-scheme://url-host[:url-port]/
44 // For Android apps (local + federated): 44 // For Android apps (local + federated):
45 // "android://<hash of cert>@<package name>" 45 // "android://<hash of cert>@<package name>/"
46 // where the hash is base64 encoded SHA512 of the app's public certificate. 46 // where the hash is base64 encoded SHA512 of the app's public certificate.
47 // For federated credentials: 47 // For federated credentials:
48 // "federation://" + origin_host + "/" + federation_host 48 // "federation://" + origin_host + "/" + federation_host
49 // For proxy auth: proxy-host/auth-realm 49 // For proxy auth: proxy-host/auth-realm
50 // For HTTP auth: url-scheme://url-host[:url-port]/auth-realm 50 // For HTTP auth: url-scheme://url-host[:url-port]/auth-realm
51 optional string signon_realm = 2; 51 optional string signon_realm = 2;
52 52
53 // For parsed web forms and Credential Manager API: 53 // For parsed web forms and Credential Manager API:
54 // url-scheme://url-host[:url-port]/path 54 // url-scheme://url-host[:url-port]/path
55 // For Android: "android://<hash of cert>@<package name>" 55 // For Android: "android://<hash of cert>@<package name>/"
56 // For proxy/HTTP auth: url-scheme://url-host[:url-port]/path 56 // For proxy/HTTP auth: url-scheme://url-host[:url-port]/path
57 optional string origin = 3; 57 optional string origin = 3;
58 58
59 // Only for web-parsed forms - the action target of the form: 59 // Only for web-parsed forms - the action target of the form:
60 // url-scheme://url-host[:url-port]/path 60 // url-scheme://url-host[:url-port]/path
61 optional string action = 4; 61 optional string action = 4;
62 62
63 // Only for web-parsed forms - the name of the element containing username. 63 // Only for web-parsed forms - the name of the element containing username.
64 optional string username_element = 5; 64 optional string username_element = 5;
65 65
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 // message. 120 // message.
121 optional EncryptedData encrypted = 1; 121 optional EncryptedData encrypted = 1;
122 // An unsynced field for use internally on the client. This field should 122 // An unsynced field for use internally on the client. This field should
123 // never be set in any network-based communications. 123 // never be set in any network-based communications.
124 optional PasswordSpecificsData client_only_encrypted_data = 2; 124 optional PasswordSpecificsData client_only_encrypted_data = 2;
125 // Password related metadata, which is sent to the server side. The field 125 // Password related metadata, which is sent to the server side. The field
126 // should never be set for full encryption users. If encryption is enabled, 126 // should never be set for full encryption users. If encryption is enabled,
127 // this field must be cleared. 127 // this field must be cleared.
128 optional PasswordSpecificsMetadata unencrypted_metadata = 3; 128 optional PasswordSpecificsMetadata unencrypted_metadata = 3;
129 } 129 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698