Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2968943003: Revert of Expand EditableLine to include non-inline text box leafs (Closed)

Created:
3 years, 5 months ago by foolip
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, aleventhal+watch_chromium.org, je_julie, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expand EditableLine to include non-inline text box leafs (patchset #6 id:100001 of https://codereview.chromium.org/2965683002/ ) Reason for revert: EditingTest.RichTextImageByCharacter is flaky (timeout) BUG=738641 Original issue's description: > Expand EditableLine to include non-inline text box leafs > > BUG=719654 > TEST=snippets involving listitems withvarious style types, images to check the workaround works. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2965683002 > Cr-Commit-Position: refs/heads/master@{#483849} > Committed: https://chromium.googlesource.com/chromium/src/+/c9e77d4e0c30f4f59042fc63cf06255805bfbade TBR=dmazzoni@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=719654 Review-Url: https://codereview.chromium.org/2968943003 Cr-Commit-Position: refs/heads/master@{#483976} Committed: https://chromium.googlesource.com/chromium/src/+/c0481c5fa5c7338d35f40f38ae0130529f7bb5c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -96 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 3 chunks +19 lines, -30 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 chunk +0 lines, -65 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
foolip
Created Revert of Expand EditableLine to include non-inline text box leafs
3 years, 5 months ago (2017-07-03 08:27:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968943003/1
3 years, 5 months ago (2017-07-03 08:28:04 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 10:12:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0481c5fa5c7338d35f40f38ae01...

Powered by Google App Engine
This is Rietveld 408576698