Expand EditableLine to include non-inline text box leafs

Expand EditableLine to include non-inline text box leafs

BUG=719654
TEST=snippets involving listitems withvarious style types, images to check the workaround works.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2965683002
Cr-Commit-Position: refs/heads/master@{#483849}
Committed: https://chromium.googlesource.com/chromium/src/+/c9e77d4e0c30f4f59042fc63cf06255805bfbade

[David Tseng, 2017-06-30 00:20:17]

Description was changed from

==========
Expand EditableLine to include non-inline text box leafs

BUG=
==========

to

==========
Expand EditableLine to include non-inline text box leafs

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-30 00:21:23]

Description was changed from

==========
Expand EditableLine to include non-inline text box leafs

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Expand EditableLine to include non-inline text box leafs

BUG=719654
TEST=snippets involving listitems withvarious style types, images to check the
workaround works.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-30 00:21:23]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-06-30 16:45:48]

lgtm, but please add at least one new regression test, so
we can ensure this continues to work as we improve Blink
and hopefully we can remove the hacks/workarounds later

[David Tseng, 2017-06-30 18:28:18]

dmazzoni@chromium.org writes:

> lgtm, but please add at least one new regression test, so
> we can ensure this continues to work as we improve Blink
> and hopefully we can remove the hacks/workarounds later

Thanks. Good idea.

Note that I added the previous on line hack as well.

Please take a look at the test (even after I submit). It demonstrates
the various issues with line data, node offsets, and more.

The test navigates through a line containing two images. The first image
exercises the next on line hack. The second image demonstrates the
previous on line hack as well as the issue with node offset and also the
hack to move to the next leaf when at the end of the current node's text
content (hack in cursors.js).

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2017-06-30 18:31:31]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 18:31:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 20:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 20:11:00]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2017-06-30 20:44:32]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-30 20:44:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2965683002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-06-30 20:44:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2017-06-30 21:06:02]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2017-06-30 21:07:37]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-30 21:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2965683002/#ps100001
(title: "We want last child of previous sibling.")

[commit-bot: I haz the power, 2017-06-30 21:07:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 22:43:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498856857454260,
"parent_rev": "772f9123d13f270ff4da5cbf445d63c564ac6abc", "commit_rev":
"c9e77d4e0c30f4f59042fc63cf06255805bfbade"}

[commit-bot: I haz the power, 2017-06-30 22:44:00]

Description was changed from

==========
Expand EditableLine to include non-inline text box leafs

BUG=719654
TEST=snippets involving listitems withvarious style types, images to check the
workaround works.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Expand EditableLine to include non-inline text box leafs

BUG=719654
TEST=snippets involving listitems withvarious style types, images to check the
workaround works.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2965683002
Cr-Commit-Position: refs/heads/master@{#483849}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9e77d4e0c30f4f59042fc63cf06...
==========

[commit-bot: I haz the power, 2017-06-30 22:44:01]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c9e77d4e0c30f4f59042fc63cf06...

[foolip, 2017-07-03 08:27:49]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2968943003/ by foolip@chromium.org.

The reason for reverting is: EditingTest.RichTextImageByCharacter is flaky
(timeout)

BUG=738641.