Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2968773002: Work around the rest of the MediaStreamConstraintsUtilAudioTest failures (Closed)

Created:
3 years, 5 months ago by Reid Kleckner
Modified:
3 years, 5 months ago
Reviewers:
Guido Urdaneta, Nico
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around the rest of the MediaStreamConstraintsUtilAudioTest failures I missed some initializer lists used in this file. These are still causing test failures on the pinned clang bots. I locally validated that all MediaStreamConstraintsUtilAudioTest tests pass now, not just the SingleBoolConstraint tests. R=guidou@chromium.org,thakis@chromium.org BUG=736309 Review-Url: https://codereview.chromium.org/2968773002 Cr-Commit-Position: refs/heads/master@{#483757} Committed: https://chromium.googlesource.com/chromium/src/+/6183dcba0a680757c19390420f76a250c4d0cbfa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/renderer/media/media_stream_constraints_util_audio_unittest.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Reid Kleckner
3 years, 5 months ago (2017-06-30 17:32:52 UTC) #1
Guido Urdaneta
lgtm
3 years, 5 months ago (2017-06-30 17:34:32 UTC) #4
Nico
lgtm
3 years, 5 months ago (2017-06-30 17:37:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968773002/1
3 years, 5 months ago (2017-06-30 18:09:37 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 18:13:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6183dcba0a680757c19390420f76...

Powered by Google App Engine
This is Rietveld 408576698