Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/renderer/media/media_stream_constraints_util_audio_unittest.cc

Issue 2968773002: Work around the rest of the MediaStreamConstraintsUtilAudioTest failures (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_constraints_util_audio_unittest.cc
diff --git a/content/renderer/media/media_stream_constraints_util_audio_unittest.cc b/content/renderer/media/media_stream_constraints_util_audio_unittest.cc
index 73fa230bec35a5bf7d94bae5d0c394e0a25cee9f..0b3ad17eaa8326e769f2d1f1125fc81bebd8dfa4 100644
--- a/content/renderer/media/media_stream_constraints_util_audio_unittest.cc
+++ b/content/renderer/media/media_stream_constraints_util_audio_unittest.cc
@@ -773,7 +773,10 @@ TEST_P(MediaStreamConstraintsUtilAudioTest, AdvancedCompatibleConstraints) {
auto result = SelectSettings();
EXPECT_TRUE(result.HasValue());
CheckDeviceDefaults(result);
- CheckBoolDefaults({&AudioCaptureSettings::render_to_associated_sink},
+ // TODO(crbug.com/736309): Fold this local when clang is fixed.
+ auto render_to_associated_sink =
+ &AudioCaptureSettings::render_to_associated_sink;
+ CheckBoolDefaults({render_to_associated_sink},
{&AudioProcessingProperties::goog_audio_mirroring}, result);
CheckGeometryDefaults(result);
EXPECT_TRUE(result.render_to_associated_sink());
@@ -794,7 +797,9 @@ TEST_P(MediaStreamConstraintsUtilAudioTest,
EXPECT_TRUE(result.HasValue());
CheckDeviceDefaults(result);
EXPECT_FALSE(result.hotword_enabled());
- CheckBoolDefaults({&AudioCaptureSettings::hotword_enabled},
+ // TODO(crbug.com/736309): Fold this local when clang is fixed.
+ auto hotword_enabled = &AudioCaptureSettings::hotword_enabled;
+ CheckBoolDefaults({hotword_enabled},
{&AudioProcessingProperties::goog_audio_mirroring,
&AudioProcessingProperties::goog_highpass_filter},
result);
@@ -814,7 +819,9 @@ TEST_P(MediaStreamConstraintsUtilAudioTest, AdvancedConflictingLastConstraint) {
auto result = SelectSettings();
EXPECT_TRUE(result.HasValue());
CheckDeviceDefaults(result);
- CheckBoolDefaults({&AudioCaptureSettings::hotword_enabled},
+ // TODO(crbug.com/736309): Fold this local when clang is fixed.
+ auto hotword_enabled = &AudioCaptureSettings::hotword_enabled;
+ CheckBoolDefaults({hotword_enabled},
{&AudioProcessingProperties::goog_audio_mirroring,
&AudioProcessingProperties::goog_highpass_filter},
result);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698