Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2968503002: [Payment Request] CanMakePayment (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] CanMakePayment BUG=602666 Review-Url: https://codereview.chromium.org/2968503002 Cr-Commit-Position: refs/heads/master@{#483466} Committed: https://chromium.googlesource.com/chromium/src/+/ddcb0e62092b24450849e7ada579025cb8f1bdc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -22 lines) Patch
M ios/chrome/browser/payments/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/ios_can_make_payment_query_factory.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/ios_can_make_payment_query_factory.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.h View 6 chunks +18 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 4 chunks +11 lines, -2 lines 0 comments Download
M ios/chrome/browser/payments/test_payment_request.h View 3 chunks +10 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm View 3 chunks +5 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/payments/js_payment_request_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/js_payment_request_manager.mm View 1 chunk +14 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_manager.mm View 5 chunks +34 lines, -6 lines 0 comments Download
M ios/chrome/browser/web/resources/payment_request.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Moe
Hi Rouslan, Please take a look.
3 years, 5 months ago (2017-06-29 17:57:12 UTC) #4
please use gerrit instead
lgtm
3 years, 5 months ago (2017-06-29 18:51:56 UTC) #7
Moe
On 2017/06/29 at 18:51:56, rouslan wrote: > lgtm Thank you.
3 years, 5 months ago (2017-06-29 19:23:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968503002/1
3 years, 5 months ago (2017-06-29 19:23:39 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 20:20:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddcb0e62092b24450849e7ada579...

Powered by Google App Engine
This is Rietveld 408576698