[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666
screenshots: https://drive.google.com/file/d/0B-GXJsF3pXyjS2ZlZHoyODRfS2c/view?usp=sharing
Review-Url: https://codereview.chromium.org/2963163002
Cr-Commit-Position: refs/heads/master@{#483836}
Committed: https://chromium.googlesource.com/chromium/src/+/90b436d76ede289c1012e0d798457f4832c63bfd

[Moe, 2017-06-29 19:23:52]

Description was changed from

==========
[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666
==========

to

==========
[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666

screenshots:
https://drive.google.com/a/chromium.org/file/d/0B-GXJsF3pXyjS2ZlZHoyODRfS2c/v...
==========

[Moe, 2017-06-29 19:23:52]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-06-29 19:24:26]

Hi Rouslan, Please take a look.

[Moe, 2017-06-29 19:24:28]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 19:24:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-06-29 19:31:49]

https://codereview.chromium.org/2963163002/diff/1/components/payments/core/pa...
File components/payments/core/payment_request_data_util.cc (right):

https://codereview.chromium.org/2963163002/diff/1/components/payments/core/pa...
components/payments/core/payment_request_data_util.cc:161: for (const
PaymentMethodData& method_data_entry : method_data) {
You should ignore all |method_data_entry| items whose |supported_methods| does
not contain "basic_card".

https://codereview.chromium.org/2963163002/diff/1/components/payments/core/pa...
components/payments/core/payment_request_data_util.cc:166: 
The outer for loop should stop here.

[Moe, 2017-06-29 20:07:40]

Description was changed from

==========
[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666

screenshots:
https://drive.google.com/a/chromium.org/file/d/0B-GXJsF3pXyjS2ZlZHoyODRfS2c/v...
==========

to

==========
[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666

screenshots:
https://drive.google.com/file/d/0B-GXJsF3pXyjS2ZlZHoyODRfS2c/view?usp=sharing
==========

[commit-bot: I haz the power, 2017-06-29 20:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:51:35]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-06-30 15:13:48]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 15:14:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-06-30 15:44:58]

Hi Rouslan, PTAL.

https://codereview.chromium.org/2963163002/diff/1/components/payments/core/pa...
File components/payments/core/payment_request_data_util.cc (right):

https://codereview.chromium.org/2963163002/diff/1/components/payments/core/pa...
components/payments/core/payment_request_data_util.cc:161: for (const
PaymentMethodData& method_data_entry : method_data) {
On 2017/06/29 at 19:31:49, rouslan wrote:
> You should ignore all |method_data_entry| items whose |supported_methods| does
not contain "basic_card".

Done.

https://codereview.chromium.org/2963163002/diff/1/components/payments/core/pa...
components/payments/core/payment_request_data_util.cc:166: 
On 2017/06/29 at 19:31:49, rouslan wrote:
> The outer for loop should stop here.

My bad. Done.

[please use gerrit instead, 2017-06-30 15:49:40]

LGTM % nit. it's my first time seeing base::ContainsValue() and I really like it
:-)

https://codereview.chromium.org/2963163002/diff/20001/components/payments/cor...
File components/payments/core/payment_request_data_util.cc (right):

https://codereview.chromium.org/2963163002/diff/20001/components/payments/cor...
components/payments/core/payment_request_data_util.cc:172: if (method_it ==
supported_methods.end())
if (!base::ContainsValue(supported_methods, "basic-card"))
  continue;

[commit-bot: I haz the power, 2017-06-30 16:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 16:20:18]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-06-30 20:47:18]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-30 20:47:19]

Thank you.

https://codereview.chromium.org/2963163002/diff/20001/components/payments/cor...
File components/payments/core/payment_request_data_util.cc (right):

https://codereview.chromium.org/2963163002/diff/20001/components/payments/cor...
components/payments/core/payment_request_data_util.cc:172: if (method_it ==
supported_methods.end())
On 2017/06/30 at 15:49:40, rouslan wrote:
> if (!base::ContainsValue(supported_methods, "basic-card"))
>   continue;

This is cool! Done.

[Moe, 2017-06-30 20:47:19]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2963163002/#ps40001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-06-30 20:47:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 21:56:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498855638205660,
"parent_rev": "c16f4f1dac9d86acaa31f2aa76bcc39048e4b207", "commit_rev":
"90b436d76ede289c1012e0d798457f4832c63bfd"}

[commit-bot: I haz the power, 2017-06-30 21:57:01]

Description was changed from

==========
[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666

screenshots:
https://drive.google.com/file/d/0B-GXJsF3pXyjS2ZlZHoyODRfS2c/view?usp=sharing
==========

to

==========
[Payment Request] Displays accepted card types (credit, debit, etc) in iOS

- Moves parsing of the accepted card types to data_util.
- Displays accepted card types in the payment method selector and credit
  card editor.

BUG=602665, 602666

screenshots:
https://drive.google.com/file/d/0B-GXJsF3pXyjS2ZlZHoyODRfS2c/view?usp=sharing
Review-Url: https://codereview.chromium.org/2963163002
Cr-Commit-Position: refs/heads/master@{#483836}
Committed:
https://chromium.googlesource.com/chromium/src/+/90b436d76ede289c1012e0d79845...
==========

[commit-bot: I haz the power, 2017-06-30 21:57:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/90b436d76ede289c1012e0d79845...