Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2968363002: Return null SelectionPaintRange if no LayoutObject. (Closed)

Created:
3 years, 5 months ago by yoichio
Modified:
3 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return null SelectionPaintRange if no LayoutObject. There is a case that CreateVisiblePosition returns {start, null} range in LayoutSelection::CalcSelection. VisibleSelection and EphemeralRange constructors prohibit such case but it is by DCHECK so we need cover on Release build failure. BUG=739996 Review-Url: https://codereview.chromium.org/2968363002 Cr-Commit-Position: refs/heads/master@{#485184} Committed: https://chromium.googlesource.com/chromium/src/+/b1601a7ae547960927ebc20de9776dc0c2e779e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
yoichio
3 years, 5 months ago (2017-07-10 01:46:09 UTC) #11
yosin_UTC9
lgtm
3 years, 5 months ago (2017-07-10 03:01:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968363002/1
3 years, 5 months ago (2017-07-10 03:01:36 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 04:45:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1601a7ae547960927ebc20de977...

Powered by Google App Engine
This is Rietveld 408576698