third_party/WebKit/Source/core/editing/LayoutSelection.cpp - Issue 2968363002: Return null SelectionPaintRange if no LayoutObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/LayoutSelection.cpp

Issue 2968363002: Return null SelectionPaintRange if no LayoutObject. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/LayoutSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/LayoutSelection.cpp b/third_party/WebKit/Source/core/editing/LayoutSelection.cpp

index bde8150398df160f23b3ab508de9e8e66f74e268..7585134d5941b192a27488d56d6015ef6bb8a0e0 100644

--- a/third_party/WebKit/Source/core/editing/LayoutSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/LayoutSelection.cpp

@@ -322,6 +322,8 @@ static SelectionPaintRange CalcSelectionPaintRange(

DCHECK(start_layout_object);

DCHECK(end_layout_object);

DCHECK(start_layout_object->View() == end_layout_object->View());

+ if (!start_layout_object || !end_layout_object)

+ return SelectionPaintRange();

return SelectionPaintRange(start_layout_object,

start_pos.ComputeEditingOffset(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »