|
|
Created:
3 years, 5 months ago by Avi (use Gerrit) Modified:
3 years, 5 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ScopedVector from third_party/libaddressinput/
BUG=554289
Review-Url: https://codereview.chromium.org/2968273002
Cr-Commit-Position: refs/heads/master@{#484924}
Committed: https://chromium.googlesource.com/chromium/src/+/4184c40a509a3634d34992c2d93d056cebf7e695
Patch Set 1 #
Total comments: 2
Messages
Total messages: 27 (21 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + rouslan@chromium.org
avi@chromium.org changed reviewers: + rouslan@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM % question https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput... File third_party/libaddressinput/chromium/chrome_storage_impl.cc (right): https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput... third_party/libaddressinput/chromium/chrome_storage_impl.cc:51: outstanding_requests_.push_back(base::MakeUnique<Request>(key, data_ready)); Would this work? outstanding_requests_.emplace_back(key, data_ready);
https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput... File third_party/libaddressinput/chromium/chrome_storage_impl.cc (right): https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput... third_party/libaddressinput/chromium/chrome_storage_impl.cc:51: outstanding_requests_.push_back(base::MakeUnique<Request>(key, data_ready)); On 2017/07/07 13:41:18, rouslan wrote: > Would this work? > > outstanding_requests_.emplace_back(key, data_ready); outstanding_requests_ is a vector of unique_ptr, so we would need to do: outstanding_requests_.emplace_back(std::unique_ptr<xxx>(... or the like. Your code would work if it were a vector of Requests directly, which is a larger change than I want to do in a CL like this.
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1499439366095500, "parent_rev": "8b02e8849339cfb3877ca98f4906b70be3c20e3d", "commit_rev": "4184c40a509a3634d34992c2d93d056cebf7e695"}
Message was sent while issue was closed.
Description was changed from ========== Remove ScopedVector from third_party/libaddressinput/ BUG=554289 ========== to ========== Remove ScopedVector from third_party/libaddressinput/ BUG=554289 Review-Url: https://codereview.chromium.org/2968273002 Cr-Commit-Position: refs/heads/master@{#484924} Committed: https://chromium.googlesource.com/chromium/src/+/4184c40a509a3634d34992c2d93d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4184c40a509a3634d34992c2d93d... |