Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1922)

Issue 2968273002: Remove ScopedVector from third_party/libaddressinput/ (Closed)

Created:
3 years, 5 months ago by Avi (use Gerrit)
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from third_party/libaddressinput/ BUG=554289 Review-Url: https://codereview.chromium.org/2968273002 Cr-Commit-Position: refs/heads/master@{#484924} Committed: https://chromium.googlesource.com/chromium/src/+/4184c40a509a3634d34992c2d93d056cebf7e695

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/libaddressinput/chromium/chrome_storage_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.cc View 2 chunks +3 lines, -5 lines 2 comments Download

Messages

Total messages: 27 (21 generated)
Avi (use Gerrit)
3 years, 5 months ago (2017-07-06 23:04:49 UTC) #12
Avi (use Gerrit)
3 years, 5 months ago (2017-07-06 23:04:50 UTC) #14
please use gerrit instead
LGTM % question https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput/chromium/chrome_storage_impl.cc File third_party/libaddressinput/chromium/chrome_storage_impl.cc (right): https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput/chromium/chrome_storage_impl.cc#newcode51 third_party/libaddressinput/chromium/chrome_storage_impl.cc:51: outstanding_requests_.push_back(base::MakeUnique<Request>(key, data_ready)); Would this work? outstanding_requests_.emplace_back(key, ...
3 years, 5 months ago (2017-07-07 13:41:18 UTC) #21
Avi (use Gerrit)
https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput/chromium/chrome_storage_impl.cc File third_party/libaddressinput/chromium/chrome_storage_impl.cc (right): https://codereview.chromium.org/2968273002/diff/1/third_party/libaddressinput/chromium/chrome_storage_impl.cc#newcode51 third_party/libaddressinput/chromium/chrome_storage_impl.cc:51: outstanding_requests_.push_back(base::MakeUnique<Request>(key, data_ready)); On 2017/07/07 13:41:18, rouslan wrote: > Would ...
3 years, 5 months ago (2017-07-07 14:56:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968273002/1
3 years, 5 months ago (2017-07-07 14:56:13 UTC) #24
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 14:59:52 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4184c40a509a3634d34992c2d93d...

Powered by Google App Engine
This is Rietveld 408576698