Remove ScopedVector from third_party/libaddressinput/

third_party/libaddressinput/chromium/chrome_storage_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "third_party/libaddressinput/chromium/chrome_storage_impl.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 21 matching lines @@
 
 void ChromeStorageImpl::Get(const std::string& key,
                             const Storage::Callback& data_ready) const {
   // |Get()| should not be const, so this is just a thunk that fixes that.
   const_cast<ChromeStorageImpl*>(this)->DoGet(key, data_ready);
 }
 
 void ChromeStorageImpl::OnPrefValueChanged(const std::string& key) {}
 
 void ChromeStorageImpl::OnInitializationCompleted(bool succeeded) {
-  for (std::vector<Request*>::iterator iter = outstanding_requests_.begin();
-       iter != outstanding_requests_.end(); ++iter) {
-    DoGet((*iter)->key, (*iter)->callback);
-  }
+  for (const auto& request : outstanding_requests_)
+    DoGet(request->key, request->callback);
 
   outstanding_requests_.clear();
 }
 
 void ChromeStorageImpl::DoGet(const std::string& key,
                               const Storage::Callback& data_ready) {
   if (!backing_store_->IsInitializationComplete()) {
-    outstanding_requests_.push_back(new Request(key, data_ready));
+    outstanding_requests_.push_back(base::MakeUnique<Request>(key, data_ready));

[please use gerrit instead, 2017/07/07 13:41:18]

Would this work?

outstanding_requests_.emplace_back(key, data_ready);

[Avi (use Gerrit), 2017/07/07 14:56:01]

outstanding_requests_ is a vector of unique_ptr, so we would need to do:

 outstanding_requests_.emplace_back(std::unique_ptr<xxx>(...

or the like. Your code would work if it were a vector of Requests directly,
which is a larger change than I want to do in a CL like this.

     return;
   }
 
   const base::Value* value = NULL;
   std::unique_ptr<std::string> data(new std::string);
   if (backing_store_->GetValue(key, &value) && value->GetAsString(data.get())) {
     data_ready(true, key, data.release());
   } else if (FallbackDataStore::Get(key, data.get())) {
     data_ready(true, key, data.release());
   } else {
     data_ready(false, key, NULL);
   }
 }
 
 ChromeStorageImpl::Request::Request(const std::string& key,
                                     const Callback& callback)
     : key(key),
       callback(callback) {}
 
 }  // namespace autofill