Fix g++ -pedantic warnings

Fix g++ -pedantic warnings.

1. Comma-terminated enumerator lists.
2. Empty macro arguments.
3. Variable-length arrays.

The first issue is definitely hitting the Mac bots.  The other two issues will quite possibly following that.

BUG= none
R=jfb@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4376d29

[JF, 2014-05-23 16:45:21]

https://codereview.chromium.org/296823013/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/296823013/diff/1/src/IceGlobalContext.cpp#new...
src/IceGlobalContext.cpp:102: llvm::OwningArrayPtr<char> NameBaseOwner(new
char[1 + Name.length()]);
Ew. VLAs aren't that evil in this context... What was the issue, just a VLA
warning? Can you allocate a statically-sized array that's realistically smaller
than any name?

[Jim Stichnoth, 2014-05-23 18:26:44]

https://codereview.chromium.org/296823013/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/296823013/diff/1/src/IceGlobalContext.cpp#new...
src/IceGlobalContext.cpp:102: llvm::OwningArrayPtr<char> NameBaseOwner(new
char[1 + Name.length()]);
On 2014/05/23 16:45:22, JF wrote:
> Ew. VLAs aren't that evil in this context... What was the issue, just a VLA
> warning? Can you allocate a statically-sized array that's realistically
smaller
> than any name?

I don't know what the maximum identifier length is (509?), but can't you make
the input string to mangleName() arbitrarily long just by embedding something
within an arbitrary nesting of namespaces?

Also, maximum-length arrays, ick.

Since it's a silly issue to start with, and it's isolated to this one function
that is just used for testing, I've rolled back the VLA-related changes and we
can revisit if the Mac bots complain.

[JF, 2014-05-23 18:31:32]

lgtm

[Jim Stichnoth, 2014-05-23 20:39:05]

Committed patchset #3 manually as r4376d29 (presubmit successful).