Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 296823013: Fix g++ -pedantic warnings (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Patch Set: Remove the empty string concatenation since macro args won't be empty Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstX8632.def ('k') | src/IceTypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX8632.cpp
diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp
index 32246c4bef031382ea1e53fe8224c2cfab032ef3..f2bdfc131bee1d96dff7e54538be20738604c785 100644
--- a/src/IceTargetLoweringX8632.cpp
+++ b/src/IceTargetLoweringX8632.cpp
@@ -101,6 +101,7 @@ void xMacroIntegrityCheck() {
#define X(val, dflt, swap, C1, C2) _tmp_##val,
FCMPX8632_TABLE
#undef X
+ _num
};
// Define a set of constants based on high-level table entries.
#define X(tag, str) static const int _table1_##tag = InstFcmp::tag;
@@ -128,6 +129,7 @@ void xMacroIntegrityCheck() {
#define X(val, C_32, C1_64, C2_64, C3_64) _tmp_##val,
ICMPX8632_TABLE
#undef X
+ _num
};
// Define a set of constants based on high-level table entries.
#define X(tag, str) static const int _table1_##tag = InstIcmp::tag;
@@ -155,6 +157,7 @@ void xMacroIntegrityCheck() {
#define X(tag, cvt, sdss, width) _tmp_##tag,
ICETYPEX8632_TABLE
#undef X
+ _num
};
// Define a set of constants based on high-level table entries.
#define X(tag, size, align, str) static const int _table1_##tag = tag;
@@ -276,14 +279,14 @@ IceString TargetX8632::getRegName(SizeT RegNum, Type Ty) const {
static IceString RegNames8[] = {
#define X(val, init, name, name16, name8, scratch, preserved, stackptr, \
frameptr, isI8, isInt, isFP) \
- "" name8,
+ name8,
REGX8632_TABLE
#undef X
};
static IceString RegNames16[] = {
#define X(val, init, name, name16, name8, scratch, preserved, stackptr, \
frameptr, isI8, isInt, isFP) \
- "" name16,
+ name16,
REGX8632_TABLE
#undef X
};
@@ -696,6 +699,9 @@ void TargetX8632::lowerArithmetic(const InstArithmetic *Inst) {
Operand *Src1Hi = hiOperand(Src1);
Variable *T_Lo = NULL, *T_Hi = NULL;
switch (Inst->getOp()) {
+ case InstArithmetic::_num:
+ llvm_unreachable("Unknown arithmetic operator");
+ break;
case InstArithmetic::Add:
_mov(T_Lo, Src0Lo);
_add(T_Lo, Src1Lo);
@@ -914,6 +920,9 @@ void TargetX8632::lowerArithmetic(const InstArithmetic *Inst) {
Variable *T_edx = NULL;
Variable *T = NULL;
switch (Inst->getOp()) {
+ case InstArithmetic::_num:
+ llvm_unreachable("Unknown arithmetic operator");
+ break;
case InstArithmetic::Add:
_mov(T, Src0);
_add(T, Src1);
« no previous file with comments | « src/IceInstX8632.def ('k') | src/IceTypes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698