content/browser/background_sync/background_sync_manager_unittest.cc - Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager_unittest.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)

Patch Set: address more comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_fetch/background_fetch_test_base.cc ('k') | content/browser/background_sync/background_sync_service_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager_unittest.cc

diff --git a/content/browser/background_sync/background_sync_manager_unittest.cc b/content/browser/background_sync/background_sync_manager_unittest.cc

index f668437a5f564e504329fbd9ef34776065fa85eb..f65652b57e515f3248cdef5729ced116c6398c5e 100644

--- a/content/browser/background_sync/background_sync_manager_unittest.cc

+++ b/content/browser/background_sync/background_sync_manager_unittest.cc

@@ -158,13 +158,15 @@ class BackgroundSyncManagerTest : public testing::Test {

bool called_1 = false;

bool called_2 = false;

helper_->context()->RegisterServiceWorker(

- GURL(kPattern1), GURL(kScript1), NULL,

+ GURL(kScript1), ServiceWorkerRegistrationOptions(GURL(kPattern1)),

+ nullptr,

base::AdaptCallbackForRepeating(

base::BindOnce(&RegisterServiceWorkerCallback, &called_1,

&sw_registration_id_1_)));

helper_->context()->RegisterServiceWorker(

- GURL(kPattern2), GURL(kScript2), NULL,

+ GURL(kScript2), ServiceWorkerRegistrationOptions(GURL(kPattern2)),

+ nullptr,

base::AdaptCallbackForRepeating(

base::BindOnce(&RegisterServiceWorkerCallback, &called_2,

&sw_registration_id_2_)));