content/browser/background_sync/background_sync_service_impl_unittest.cc - Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_service_impl_unittest.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)

Patch Set: address more comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager_unittest.cc ('k') | content/browser/notifications/platform_notification_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_service_impl_unittest.cc

diff --git a/content/browser/background_sync/background_sync_service_impl_unittest.cc b/content/browser/background_sync/background_sync_service_impl_unittest.cc

index e70bbd4001f2dd2f5009cdaaaa8f1f820b369232..4c1bfe594da76bcc1a24a6c917a3ca6bdd948bfc 100644

--- a/content/browser/background_sync/background_sync_service_impl_unittest.cc

+++ b/content/browser/background_sync/background_sync_service_impl_unittest.cc

@@ -163,7 +163,8 @@ class BackgroundSyncServiceImplTest : public testing::Test {

void CreateServiceWorkerRegistration() {

bool called = false;

embedded_worker_helper_->context()->RegisterServiceWorker(

- GURL(kServiceWorkerPattern), GURL(kServiceWorkerScript), NULL,

+ GURL(kServiceWorkerScript),

+ ServiceWorkerRegistrationOptions(GURL(kServiceWorkerPattern)), nullptr,

base::AdaptCallbackForRepeating(base::BindOnce(

&RegisterServiceWorkerCallback, &called, &sw_registration_id_)));

base::RunLoop().RunUntilIdle();