Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/background_fetch/background_fetch_test_base.cc

Issue 2968123002: Introduce ServiceWorkerRegistrationOptions struct for service worker options (Closed)
Patch Set: address more comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc ('k') | content/browser/background_sync/background_sync_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/background_fetch/background_fetch_test_base.cc
diff --git a/content/browser/background_fetch/background_fetch_test_base.cc b/content/browser/background_fetch/background_fetch_test_base.cc
index 9314f19e96e0d83b7c51618bc1d88b115e0d4e58..bdf650751f40fcea7c30a501b1333ddda3368911 100644
--- a/content/browser/background_fetch/background_fetch_test_base.cc
+++ b/content/browser/background_fetch/background_fetch_test_base.cc
@@ -22,6 +22,7 @@
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_registration.h"
#include "content/common/service_worker/service_worker_status_code.h"
+#include "content/common/service_worker/service_worker_types.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/download_item.h"
#include "content/public/browser/download_url_parameters.h"
@@ -240,7 +241,8 @@ bool BackgroundFetchTestBase::CreateRegistrationId(
{
base::RunLoop run_loop;
embedded_worker_test_helper_.context()->RegisterServiceWorker(
- origin_.GetURL(), script_url, nullptr /* provider_host */,
+ script_url, ServiceWorkerRegistrationOptions(origin_.GetURL()),
+ nullptr /* provider_host */,
base::Bind(&DidRegisterServiceWorker, &service_worker_registration_id,
run_loop.QuitClosure()));
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc ('k') | content/browser/background_sync/background_sync_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698