mus-gpu: Fix handling channel establish requests.

mus-gpu: Fix handling channel establish requests.

A couple of changes:
. If a request for establishing a gpu channel is made from the callback
  of a failed previous request, then make sure the request is processed
  correctly. Without this fix, |ui::Gpu::establish_callbacks_| is
  changed while iterating over it, causing errors.
. If a request for a gpu channel was successful, then the subsequent
  requests should be responded synchronously. This is the current
  behaviour of BrowserGpuChannelHostFactory.

BUG=609316
Review-Url: https://codereview.chromium.org/2968053002
Cr-Commit-Position: refs/heads/master@{#484664}
Committed: https://chromium.googlesource.com/chromium/src/+/519814bd8b4235d2f1702ebdc306a16c5b03707f

[sadrul, 2017-07-05 20:57:41]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 20:57:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-07-05 21:49:28]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 21:49:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-07-05 21:54:13]

Description was changed from

==========
mus-gpu: Fix handling channel establish requests.

If a request for establishing a gpu channel is made from the callback
of a failed previous request, then make sure the request is processed
correctly. Without this fix, |ui::Gpu::establish_callbacks_| is changed
while iterating over it, causing errors.

BUG=609316
==========

to

==========
mus-gpu: Fix handling channel establish requests.

A couple of changes:
. If a request for establishing a gpu channel is made from the callback
  of a failed previous request, then make sure the request is processed
  correctly. Without this fix, |ui::Gpu::establish_callbacks_| is
  changed while iterating over it, causing errors.
. If a request for a gpu channel was successful, then the subsequent
  requests should be responded synchronously. This is the current
  behaviour of BrowserGpuChannelHostFactory.

BUG=609316
==========

[sadrul, 2017-07-05 22:02:15]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2017-07-05 22:02:16]

(for reference, the corresponding browser-test for the synchronous-response is
at
https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_ipc_browsertests...)

[piman, 2017-07-05 22:16:40]

LGTM, but see nit for a good useful check we could have

https://codereview.chromium.org/2968053002/diff/20001/services/ui/public/cpp/...
File services/ui/public/cpp/tests/gpu_unittest.cc (right):

https://codereview.chromium.org/2968053002/diff/20001/services/ui/public/cpp/...
services/ui/public/cpp/tests/gpu_unittest.cc:132:
scoped_refptr<gpu::GpuChannelHost> host) { callback.Run(); },
nit: Is there a way to check that the second establish will succeed (assuming we
don't fail the request on the impl side)?

[sadrul, 2017-07-05 22:58:38]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 22:58:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-07-05 22:59:56]

Mind taking another look at the updated test (because I am not totally sure if I
understood you right)? Thanks!

https://codereview.chromium.org/2968053002/diff/20001/services/ui/public/cpp/...
File services/ui/public/cpp/tests/gpu_unittest.cc (right):

https://codereview.chromium.org/2968053002/diff/20001/services/ui/public/cpp/...
services/ui/public/cpp/tests/gpu_unittest.cc:132:
scoped_refptr<gpu::GpuChannelHost> host) { callback.Run(); },
On 2017/07/05 22:16:40, piman wrote:
> nit: Is there a way to check that the second establish will succeed (assuming
we
> don't fail the request on the impl side)?

I have made the second request to succeed, and verify that a GpuChannelHost is
created correctly.

[commit-bot: I haz the power, 2017-07-06 00:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 00:09:52]

Dry run: This issue passed the CQ dry run.

[piman, 2017-07-06 17:14:17]

LGTM, thanks, that's what I was looking for!

[sadrul, 2017-07-06 17:51:06]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-07-06 17:51:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 17:58:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499363466333830,
"parent_rev": "36b3d9c79daa96f98863b47a8281e832fc503870", "commit_rev":
"519814bd8b4235d2f1702ebdc306a16c5b03707f"}

[commit-bot: I haz the power, 2017-07-06 17:58:47]

Description was changed from

==========
mus-gpu: Fix handling channel establish requests.

A couple of changes:
. If a request for establishing a gpu channel is made from the callback
  of a failed previous request, then make sure the request is processed
  correctly. Without this fix, |ui::Gpu::establish_callbacks_| is
  changed while iterating over it, causing errors.
. If a request for a gpu channel was successful, then the subsequent
  requests should be responded synchronously. This is the current
  behaviour of BrowserGpuChannelHostFactory.

BUG=609316
==========

to

==========
mus-gpu: Fix handling channel establish requests.

A couple of changes:
. If a request for establishing a gpu channel is made from the callback
  of a failed previous request, then make sure the request is processed
  correctly. Without this fix, |ui::Gpu::establish_callbacks_| is
  changed while iterating over it, causing errors.
. If a request for a gpu channel was successful, then the subsequent
  requests should be responded synchronously. This is the current
  behaviour of BrowserGpuChannelHostFactory.

BUG=609316

Review-Url: https://codereview.chromium.org/2968053002
Cr-Commit-Position: refs/heads/master@{#484664}
Committed:
https://chromium.googlesource.com/chromium/src/+/519814bd8b4235d2f1702ebdc306...
==========

[commit-bot: I haz the power, 2017-07-06 17:58:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/519814bd8b4235d2f1702ebdc306...