mus-gpu: Fix handling channel establish requests.

services/ui/public/cpp/tests/gpu_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/public/cpp/gpu/gpu.h"
 
 #include "base/callback_helpers.h"
 #include "base/test/scoped_task_environment.h"
 #include "gpu/config/gpu_info.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
@@ skipping 15 matching lines @@
   }
 
   void WaitUntilChannelRequest() {
     DCHECK(quit_closure_.is_null());
     base::RunLoop run_loop;
     quit_closure_ = run_loop.QuitClosure();
     run_loop.Run();
     quit_closure_ = base::Closure();
   }
 
-  bool RespondToGpuChannelRequests() {
+  bool RespondToGpuChannelRequests(bool success = false) {
     if (establish_channel_callback_.is_null())
       return false;
     constexpr int client_id = 1;
     mojo::ScopedMessagePipeHandle handle;
+    if (success)
+      handle = std::move(mojo::MessagePipe().handle0);
     base::ResetAndReturn(&establish_channel_callback_)
         .Run(client_id, std::move(handle), gpu::GPUInfo());
     return true;
   }
 
   // ui::mojom::Gpu overrides:
   void EstablishGpuChannel(
       const EstablishGpuChannelCallback& callback) override {
     establish_channel_callback_ = callback;
     if (!quit_closure_.is_null())
@@ skipping 63 matching lines @@
   gpu()->EstablishGpuChannel(callback);
   gpu()->EstablishGpuChannel(callback);
   EXPECT_EQ(2, counter);
   gpu_impl()->WaitUntilChannelRequest();
 
   EXPECT_TRUE(gpu_impl()->RespondToGpuChannelRequests());
   run_loop.Run();
   EXPECT_EQ(0, counter);
 }
 
+// Tests that a new request for establishing a gpu channel from a callback of a
+// previous callback is processed correctly.
+TEST_F(GpuTest, EstablishRequestOnFailureOnPreviousRequest) {
+  base::RunLoop run_loop;
+  auto callback = base::Bind(
+      [](const base::Closure& callback,
+         scoped_refptr<gpu::GpuChannelHost> host) { callback.Run(); },

[piman, 2017/07/05 22:16:40]

nit: Is there a way to check that the second establish will succeed (assuming we
don't fail the request on the impl side)?

[sadrul, 2017/07/05 22:59:56]

I have made the second request to succeed, and verify that a GpuChannelHost is
created correctly.

+      run_loop.QuitClosure());
+  gpu()->EstablishGpuChannel(base::Bind(
+      [](ui::Gpu* gpu, const gpu::GpuChannelEstablishedCallback& callback,
+         scoped_refptr<gpu::GpuChannelHost> host) {
+        DCHECK(!host);
+        gpu->EstablishGpuChannel(callback);
+      },
+      gpu(), callback));
+  gpu_impl()->WaitUntilChannelRequest();
+  EXPECT_TRUE(gpu_impl()->RespondToGpuChannelRequests());
+
+  // Responding to the first request would issue a second request immediately.
+  // So wait for that request to reach the TestGpuImpl, and have that respond
+  // again. That should run quit-closure of |run_loop|.
+  gpu_impl()->WaitUntilChannelRequest();
+  EXPECT_TRUE(gpu_impl()->RespondToGpuChannelRequests());
+  run_loop.Run();
+}
+
+// Tests that if a request for a gpu channel succeeded, then subsequent requests
+// are met synchronously.
+TEST_F(GpuTest, EstablishRequestResponseSynchronouslyOnSuccess) {
+  scoped_refptr<gpu::GpuChannelHost> host;
+  base::RunLoop run_loop;
+  gpu()->EstablishGpuChannel(base::Bind(
+      [](scoped_refptr<gpu::GpuChannelHost>* out_host,
+         const base::Closure& callback,
+         scoped_refptr<gpu::GpuChannelHost> host) {
+        *out_host = std::move(host);
+        callback.Run();
+      },
+      &host, run_loop.QuitClosure()));
+  gpu_impl()->WaitUntilChannelRequest();
+  EXPECT_TRUE(gpu_impl()->RespondToGpuChannelRequests(true /* success */));
+  EXPECT_FALSE(host);
+  run_loop.Run();
+  EXPECT_TRUE(host);
+
+  int counter = 0;
+  auto callback =
+      base::Bind([](int* counter,
+                    scoped_refptr<gpu::GpuChannelHost> host) { ++(*counter); },
+                 &counter);
+  gpu()->EstablishGpuChannel(callback);
+  EXPECT_EQ(1, counter);
+}
+
 }  // namespace ui