DRP: Make secure proxy check URL a DRP param

DRP: Make secure proxy check URL a DRP param

Make secure proxy check URL as a data reduction proxy param instead of
a config value. This further cuts down on the functionality provided
by data_reduction_proxy_config_values class.

Also, remove unused flags for carrier testing, and for setting warmup url.

BUG=597768
Review-Url: https://codereview.chromium.org/2967993002
Cr-Commit-Position: refs/heads/master@{#485412}
Committed: https://chromium.googlesource.com/chromium/src/+/aaed3d6688dd2599809a4ddb50e8d2414f5e96ef

[tbansal1, 2017-07-05 07:33:52]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:34:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 07:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 07:55:09]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tbansal1, 2017-07-05 13:56:57]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 13:57:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 15:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 15:02:59]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-07-05 16:14:32]

Description was changed from

==========
drp

BUG=
==========

to

==========
DRP: Make secure proxy check URL a DRP param

Make secure proxy check URL as a data reduction proxy param instead of
a config value. This further cuts down on the functionality provided
by data_reduction_proxy_config_values class.

Also, remove unused flags for carrier testing, and for setting warmup url.

BUG=
==========

[tbansal1, 2017-07-05 16:15:51]

Description was changed from

==========
DRP: Make secure proxy check URL a DRP param

Make secure proxy check URL as a data reduction proxy param instead of
a config value. This further cuts down on the functionality provided
by data_reduction_proxy_config_values class.

Also, remove unused flags for carrier testing, and for setting warmup url.

BUG=
==========

to

==========
DRP: Make secure proxy check URL a DRP param

Make secure proxy check URL as a data reduction proxy param instead of
a config value. This further cuts down on the functionality provided
by data_reduction_proxy_config_values class.

Also, remove unused flags for carrier testing, and for setting warmup url.

BUG=597768
==========

[tbansal1, 2017-07-05 16:15:58]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-07-05 16:16:23]

tbansal@chromium.org changed reviewers:
+ megjablon@chromium.org

[tbansal1, 2017-07-05 16:16:23]

megjablon: ptal. Thanks.

[tbansal1, 2017-07-10 17:41:05]

ping!! Thanks.

[tbansal1, 2017-07-10 17:44:26]

megjablon: ping. Thanks.

[megjablon, 2017-07-10 18:35:13]

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(left):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:521:
switches::kDataReductionProxyWarmupURL);
Can kDataReductionProxyWarmupURL be removed too?

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:558:
std::string DataReductionProxyParams::GetDefaultSecureProxyCheckURL() const {
Is this method needed anymore?

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:175:
GURL secure_proxy_check_url();
GetSecureProxyCheckURL()?

[tbansal1, 2017-07-10 18:43:06]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2017-07-10 20:10:07]

megjablon: ptal. Thanks.

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(left):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:521:
switches::kDataReductionProxyWarmupURL);
On 2017/07/10 18:35:13, megjablon wrote:
> Can kDataReductionProxyWarmupURL be removed too?

Yes, switches.h removes it.

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:558:
std::string DataReductionProxyParams::GetDefaultSecureProxyCheckURL() const {
On 2017/07/10 18:35:13, megjablon wrote:
> Is this method needed anymore?

Yes, it is still needed. This is for the secure proxy / canary check  (not the
warmup).

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:175:
GURL secure_proxy_check_url();
On 2017/07/10 18:35:13, megjablon wrote:
> GetSecureProxyCheckURL()?

Done.

[tbansal1, 2017-07-10 20:10:09]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 20:10:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-07-10 20:20:08]

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:558:
std::string DataReductionProxyParams::GetDefaultSecureProxyCheckURL() const {
On 2017/07/10 20:10:06, tbansal1 wrote:
> On 2017/07/10 18:35:13, megjablon wrote:
> > Is this method needed anymore?
> 
> Yes, it is still needed. This is for the secure proxy / canary check  (not the
> warmup).

I don't see this being called anywhere other than the test_utils where those
calls were removed and in params.cc where you are now using
kDefaultSecureProxyCheckUrl directly.

[tbansal1, 2017-07-10 20:29:51]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 20:30:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-07-10 20:35:18]

megjablon: ptal.

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/2967993002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:558:
std::string DataReductionProxyParams::GetDefaultSecureProxyCheckURL() const {
On 2017/07/10 20:20:08, megjablon wrote:
> On 2017/07/10 20:10:06, tbansal1 wrote:
> > On 2017/07/10 18:35:13, megjablon wrote:
> > > Is this method needed anymore?
> > 
> > Yes, it is still needed. This is for the secure proxy / canary check  (not
the
> > warmup).
> 
> I don't see this being called anywhere other than the test_utils where those
> calls were removed and in params.cc where you are now using
> kDefaultSecureProxyCheckUrl directly.

Done.

[megjablon, 2017-07-10 20:36:54]

lgtm

[commit-bot: I haz the power, 2017-07-10 21:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 21:42:19]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-07-10 21:46:36]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-07-10 21:46:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 21:52:50]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499723196187570,
"parent_rev": "e68b8951056caed4d22e8a41f7b0e3a6a606e6f9", "commit_rev":
"aaed3d6688dd2599809a4ddb50e8d2414f5e96ef"}

[commit-bot: I haz the power, 2017-07-10 21:53:04]

Description was changed from

==========
DRP: Make secure proxy check URL a DRP param

Make secure proxy check URL as a data reduction proxy param instead of
a config value. This further cuts down on the functionality provided
by data_reduction_proxy_config_values class.

Also, remove unused flags for carrier testing, and for setting warmup url.

BUG=597768
==========

to

==========
DRP: Make secure proxy check URL a DRP param

Make secure proxy check URL as a data reduction proxy param instead of
a config value. This further cuts down on the functionality provided
by data_reduction_proxy_config_values class.

Also, remove unused flags for carrier testing, and for setting warmup url.

BUG=597768

Review-Url: https://codereview.chromium.org/2967993002
Cr-Commit-Position: refs/heads/master@{#485412}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaed3d6688dd2599809a4ddb50e8...
==========

[commit-bot: I haz the power, 2017-07-10 21:53:07]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/aaed3d6688dd2599809a4ddb50e8...