Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

Issue 2967993002: DRP: Make secure proxy check URL a DRP param (Closed)
Patch Set: megjablon comment Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
index ed5cd106f48b153e71fa4204279ef02b784eaa8a..f65969a03393ef02e30abda2dcdb58ce4182f0e0 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
@@ -170,6 +170,10 @@ bool GetOverrideProxiesForHttpFromCommandLine(
// Returns the name of the server side experiment field trial.
const char* GetServerExperimentsFieldTrialName();
+// Returns the URL to check to decide if the secure proxy origin should be
+// used.
+GURL GetSecureProxyCheckURL();
+
// Returns true if fetching of the warmup URL is enabled.
bool FetchWarmupURLEnabled();
@@ -209,8 +213,6 @@ class DataReductionProxyParams : public DataReductionProxyConfigValues {
const std::vector<DataReductionProxyServer>& proxies_for_http()
const override;
- const GURL& secure_proxy_check_url() const override;
-
protected:
// Test constructor that optionally won't call Init();
explicit DataReductionProxyParams(bool should_call_init);
@@ -228,7 +230,6 @@ class DataReductionProxyParams : public DataReductionProxyConfigValues {
// and an empty string otherwise.
virtual std::string GetDefaultOrigin() const;
virtual std::string GetDefaultFallbackOrigin() const;
- virtual std::string GetDefaultSecureProxyCheckURL() const;
private:
std::vector<DataReductionProxyServer> proxies_for_http_;
@@ -236,8 +237,6 @@ class DataReductionProxyParams : public DataReductionProxyConfigValues {
net::ProxyServer origin_;
net::ProxyServer fallback_origin_;
- GURL secure_proxy_check_url_;
-
bool use_override_proxies_for_http_;
std::vector<DataReductionProxyServer> override_data_reduction_proxy_servers_;

Powered by Google App Engine
This is Rietveld 408576698