Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2967683002: Clean up some code in plugins (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -107 lines) Patch
M pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart View 4 chunks +18 lines, -69 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 4 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-06-30 17:34:24 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-30 17:35:34 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-06-30 17:39:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f4420562cbc8e95cf7ed3f35a417ef42f4c7cba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698