Clean up some code in plugins

pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection';
 import 'dart:convert' hide JsonDecoder;
 
 import 'package:analyzer_plugin/protocol/protocol.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart';
 import 'package:analyzer_plugin/protocol/protocol_generated.dart';
@@ skipping 113 matching lines @@
       return false;
     }
   }
   return true;
 }
 
 /**
  * Translate the input [map], applying [keyCallback] to all its keys, and
  * [valueCallback] to all its values.
  */
-Map/*<KR, VR>*/ mapMap/*<KP, VP, KR, VR>*/(Map/*<KP, VP>*/ map,
-    {dynamic/*=KR*/ keyCallback(/*<KP>*/ key),
-    dynamic/*=VR*/ valueCallback(/*<VP>*/ value)}) {
-  Map/*<KR, VR>*/ result = new HashMap/*<KR, VR>*/();
+Map<KR, VR> mapMap<KP, VP, KR, VR>(Map<KP, VP> map,
+    {KR keyCallback(KP key), VR valueCallback(VP value)}) {
+  Map<KR, VR> result = new HashMap<KR, VR>();
   map.forEach((key, value) {
-    Object/*=KR*/ resultKey;
-    Object/*=VR*/ resultValue;
+    KR resultKey;
+    VR resultValue;
     if (keyCallback != null) {
       resultKey = keyCallback(key);
     } else {
-      resultKey = key as Object/*=KR*/;
+      resultKey = key as KR;
     }
     if (valueCallback != null) {
       resultValue = valueCallback(value);
     } else {
-      resultValue = value as Object/*=VR*/;
+      resultValue = value as VR;
     }
     result[resultKey] = resultValue;
   });
   return result;
 }
 
 RefactoringProblemSeverity maxRefactoringProblemSeverity(
     RefactoringProblemSeverity a, RefactoringProblemSeverity b) {
   if (b == null) {
     return a;
@@ skipping 58 matching lines @@
   }
   if (kind == RefactoringKind.MOVE_FILE) {
     return new MoveFileOptions.fromJson(jsonDecoder, jsonPath, json);
   }
   if (kind == RefactoringKind.RENAME) {
     return new RenameOptions.fromJson(jsonDecoder, jsonPath, json);
   }
   return null;
 }
 
-///**
-// * Create a [RefactoringFeedback] corresponding the given [kind].
-// */
-//RefactoringFeedback refactoringFeedbackFromJson(
-//    JsonDecoder jsonDecoder, String jsonPath, Object json, Map feedbackJson) {
-//  RefactoringKind kind = jsonDecoder.refactoringKind;
-//  if (kind == RefactoringKind.EXTRACT_LOCAL_VARIABLE) {
-//    return new ExtractLocalVariableFeedback.fromJson(
-//        jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.EXTRACT_METHOD) {
-//    return new ExtractMethodFeedback.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.INLINE_LOCAL_VARIABLE) {
-//    return new InlineLocalVariableFeedback.fromJson(
-//        jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.INLINE_METHOD) {
-//    return new InlineMethodFeedback.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.RENAME) {
-//    return new RenameFeedback.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  return null;
-//}
-//
-///**
-// * Create a [RefactoringOptions] corresponding the given [kind].
-// */
-//RefactoringOptions refactoringOptionsFromJson(JsonDecoder jsonDecoder,
-//    String jsonPath, Object json, RefactoringKind kind) {
-//  if (kind == RefactoringKind.EXTRACT_LOCAL_VARIABLE) {
-//    return new ExtractLocalVariableOptions.fromJson(
-//        jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.EXTRACT_METHOD) {
-//    return new ExtractMethodOptions.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.INLINE_METHOD) {
-//    return new InlineMethodOptions.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.MOVE_FILE) {
-//    return new MoveFileOptions.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  if (kind == RefactoringKind.RENAME) {
-//    return new RenameOptions.fromJson(jsonDecoder, jsonPath, json);
-//  }
-//  return null;
-//}
-
 /**
  * Type of callbacks used to decode parts of JSON objects.  [jsonPath] is a
  * string describing the part of the JSON object being decoded, and [value] is
  * the part to decode.
  */
 typedef E JsonDecoderCallback<E>(String jsonPath, Object value);
 
 /**
  * Instances of the class [HasToJson] implement [toJson] method that returns
  * a JSON presentation.
@@ skipping 46 matching lines @@
     }
     throw mismatch(jsonPath, 'int', json);
   }
 
   /**
    * Decode a JSON object that is expected to be a List. The [decoder] is used
    * to decode the items in the list.
    *
    * The type parameter [E] is the expected type of the elements in the list.
    */
-  List/*<E>*/ decodeList/*<E>*/(String jsonPath, Object json,
-      [JsonDecoderCallback/*<E>*/ decoder]) {
+  List<E> decodeList<E>(String jsonPath, Object json,
+      [JsonDecoderCallback<E> decoder]) {
     if (json == null) {
-      return/*<E>*/ [];
+      return <E>[];
     } else if (json is List) {
-      List/*<E>*/ result = /*<E>*/ [];
+      List<E> result = <E>[];
       for (int i = 0; i < json.length; i++) {
         result.add(decoder('$jsonPath[$i]', json[i]));
       }
       return result;
     } else {
       throw mismatch(jsonPath, 'List', json);
     }
   }
 
   /**
    * Decode a JSON object that is expected to be a Map.  [keyDecoder] is used
    * to decode the keys, and [valueDecoder] is used to decode the values.
    */
-  Map/*<K, V>*/ decodeMap/*<K, V>*/(String jsonPath, Object json,
-      {JsonDecoderCallback/*<K>*/ keyDecoder,
-      JsonDecoderCallback/*<V>*/ valueDecoder}) {
+  Map<K, V> decodeMap<K, V>(String jsonPath, Object json,
+      {JsonDecoderCallback<K> keyDecoder,
+      JsonDecoderCallback<V> valueDecoder}) {
     if (json == null) {
       return {};
     } else if (json is Map) {
-      Map/*<K, V>*/ result = /*<K, V>*/ {};
+      Map<K, V> result = <K, V>{};
       json.forEach((String key, value) {
-        Object/*=K*/ decodedKey;
+        K decodedKey;
         if (keyDecoder != null) {
           decodedKey = keyDecoder('$jsonPath.key', key);
         } else {
-          decodedKey = key as Object/*=K*/;
+          decodedKey = key as K;
         }
         if (valueDecoder != null) {
           value = valueDecoder('$jsonPath[${JSON.encode(key)}]', value);
         }
-        result[decodedKey] = value as Object/*=V*/;
+        result[decodedKey] = value as V;
       });
       return result;
     } else {
       throw mismatch(jsonPath, 'Map', json);
     }
   }
 
   /**
    * Decode a JSON object that is expected to be a string.
    */
@@ skipping 123 matching lines @@
 /**
  * The result data associated with a response.
  */
 abstract class ResponseResult implements HasToJson {
   /**
    * Return a response whose result data is this object for the request with the
    * given [id], where the request was received at the given [requestTime].
    */
   Response toResponse(String id, int requestTime);
 }