Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart

Issue 2967683002: Clean up some code in plugins (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart
diff --git a/pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart b/pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart
index e712d08b25d380eb81ed219ccd7b6bcbcdff9ee7..3b90b51e4c9425947016d09baabae300dde31d56 100644
--- a/pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart
+++ b/pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart
@@ -121,7 +121,6 @@ class PluginIsolateChannel implements PluginCommunicationChannel {
{Function onError, void onDone()}) {
void onData(data) {
Map<String, Object> requestMap = data;
-// print('[plugin] Received request: ${JSON.encode(requestMap)}');
Request request = new Request.fromJson(requestMap);
if (request != null) {
onRequest(request);
@@ -138,14 +137,12 @@ class PluginIsolateChannel implements PluginCommunicationChannel {
@override
void sendNotification(Notification notification) {
Map<String, Object> json = notification.toJson();
-// print('[plugin] Send notification: ${JSON.encode(json)}');
_sendPort.send(json);
}
@override
void sendResponse(Response response) {
Map<String, Object> json = response.toJson();
-// print('[plugin] Send response: ${JSON.encode(json)}');
_sendPort.send(json);
}
}
« no previous file with comments | « no previous file | pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698