Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Issue 2967283002: Revert of [devil] Always set permissions on install (Closed)

Created:
3 years, 5 months ago by jbudorick
Modified:
3 years, 5 months ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [devil] Always set permissions on install (patchset #1 id:1 of https://codereview.chromium.org/2963303002/ ) Reason for revert: breaking a few different suites: https://bugs.chromium.org/p/chromium/issues/detail?id=739531 Original issue's description: > [devil] Always set permissions on install > > Grant required app permissions on apk Install, regardless of whether > the apk was already installed or not. > > This caused some issues where developers manually installed apks and > then test runners would fail due to the missing permissions. > > BUG=chromium:732724 > > Review-Url: https://codereview.chromium.org/2963303002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c8957d6c0705d7d93063430b911b453bfa3356bf TBR=primiano@chromium.org,perezju@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:732724 Review-Url: https://codereview.chromium.org/2967283002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/22871a546c9e7779d7ae6f26ca0bcb4b36e651ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M devil/devil/android/device_utils.py View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbudorick
Created Revert of [devil] Always set permissions on install
3 years, 5 months ago (2017-07-05 22:50:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967283002/1
3 years, 5 months ago (2017-07-05 22:50:22 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 22:50:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698