Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2963303002: [devil] Always set permissions on install (Closed)

Created:
3 years, 5 months ago by perezju
Modified:
3 years, 5 months ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[devil] Always set permissions on install Grant required app permissions on apk Install, regardless of whether the apk was already installed or not. This caused some issues where developers manually installed apks and then test runners would fail due to the missing permissions. BUG=chromium:732724 Review-Url: https://codereview.chromium.org/2963303002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c8957d6c0705d7d93063430b911b453bfa3356bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M devil/devil/android/device_utils.py View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
perezju
Also verified that this fixes the issue on crbug.com/732724; the tests now would have run ...
3 years, 5 months ago (2017-06-30 14:50:51 UTC) #2
Primiano Tucci (use gerrit)
LGTM thanks
3 years, 5 months ago (2017-07-03 09:57:49 UTC) #3
jbudorick
lgtm
3 years, 5 months ago (2017-07-05 16:05:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963303002/1
3 years, 5 months ago (2017-07-05 16:20:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c8957d6c0705d7d93063430b911b453bfa3356bf
3 years, 5 months ago (2017-07-05 17:19:32 UTC) #9
jbudorick
3 years, 5 months ago (2017-07-05 22:50:14 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2967283002/ by jbudorick@chromium.org.

The reason for reverting is: breaking a few different suites:
https://bugs.chromium.org/p/chromium/issues/detail?id=739531.

Powered by Google App Engine
This is Rietveld 408576698