[Payments] Add an entry for Payment Request to chrome://flags on iOS

[Payments] Add an entry for Payment Request to chrome://flags on iOS

BUG=704551
TEST=ios_chrome_unittests

Review-Url: https://codereview.chromium.org/2967273002
Cr-Commit-Position: refs/heads/master@{#484727}
Committed: https://chromium.googlesource.com/chromium/src/+/9b4c11d8713095ce1ce9110822f282367d218e19

[Mathieu, 2017-07-05 20:37:39]

mathp@chromium.org changed reviewers:
+ sdefresne@chromium.org

[Mathieu, 2017-07-05 20:37:40]

Hi Sylvain, PTAL

We are not enabling this feature yet, but in M61 people would be able to turn it
on via chrome://flags.

[sdefresne, 2017-07-06 13:06:45]

sdefresne@chromium.org changed reviewers:
+ noyau@chromium.org

[sdefresne, 2017-07-06 13:06:45]

lgtm

Adding noyau as additional reviewer as they are refactoring the flags.

[Mathieu, 2017-07-06 13:59:57]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 14:00:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 15:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 15:11:19]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-07-06 15:26:49]

Patchset #3 (id:40001) has been deleted

[Mathieu, 2017-07-06 15:28:36]

Thanks. Moved the check to the feature code, PTAL Eric.

[noyau (Ping after 24h), 2017-07-06 15:33:28]

Thanks, let's get rid of the iOS custom way of setting flags.

lgtm

https://codereview.chromium.org/2967273002/diff/20001/ios/chrome/browser/expe...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/2967273002/diff/20001/ios/chrome/browser/expe...
ios/chrome/browser/experimental_flags.mm:176: bool IsPaymentRequestEnabled() {
Can you get rid of this function and use IsEnabled directly? I'd like to get rid
of this whole file ultimately.

[Mathieu, 2017-07-06 15:34:17]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-07-06 15:34:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2967273002/#ps60001
(title: "Moved enabled check to feature code")

[Mathieu, 2017-07-06 15:34:30]

Submitting...

https://codereview.chromium.org/2967273002/diff/20001/ios/chrome/browser/expe...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/2967273002/diff/20001/ios/chrome/browser/expe...
ios/chrome/browser/experimental_flags.mm:176: bool IsPaymentRequestEnabled() {
On 2017/07/06 15:33:28, noyau (Ping after 24h) wrote:
> Can you get rid of this function and use IsEnabled directly? I'd like to get
rid
> of this whole file ultimately.

Done!

[commit-bot: I haz the power, 2017-07-06 15:34:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 16:01:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 16:01:02]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Mathieu, 2017-07-06 16:04:10]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-07-06 16:04:11]

The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2967273002/#ps80001
(title: "deps fix")

[commit-bot: I haz the power, 2017-07-06 16:04:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 17:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 17:45:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-07-06 18:39:24]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-07-06 18:39:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 20:24:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499366364235100,
"parent_rev": "2623cc8fb8fb6f986708e4ce3e9804630fb57071", "commit_rev":
"9b4c11d8713095ce1ce9110822f282367d218e19"}

[commit-bot: I haz the power, 2017-07-06 20:24:32]

Description was changed from

==========
[Payments] Add an entry for Payment Request to chrome://flags on iOS

BUG=704551
TEST=ios_chrome_unittests
==========

to

==========
[Payments] Add an entry for Payment Request to chrome://flags on iOS

BUG=704551
TEST=ios_chrome_unittests

Review-Url: https://codereview.chromium.org/2967273002
Cr-Commit-Position: refs/heads/master@{#484727}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b4c11d8713095ce1ce9110822f2...
==========

[commit-bot: I haz the power, 2017-07-06 20:24:34]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9b4c11d8713095ce1ce9110822f2...