[Payments] Add an entry for Payment Request to chrome://flags on iOS

ios/chrome/browser/experimental_flags.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file can be empty. Its purpose is to contain the relatively short lived
 // definitions required for experimental flags.
 
 #include "ios/chrome/browser/experimental_flags.h"
 
 #include <dispatch/dispatch.h>
 #import <Foundation/Foundation.h>
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/password_manager/core/common/password_manager_features.h"
+#include "components/payments/core/features.h"
 #include "components/signin/core/common/signin_switches.h"
 #include "components/variations/variations_associated_data.h"
 #include "ios/chrome/browser/chrome_switches.h"
 #include "ios/web/public/web_view_creation_util.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
@@ skipping 133 matching lines @@
   std::string group_name =
       base::FieldTrialList::FindFullName("PasswordGeneration");
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kEnableIOSPasswordGeneration))
     return true;
   if (command_line->HasSwitch(switches::kDisableIOSPasswordGeneration))
     return false;
   return group_name != "Disabled";
 }
 
 bool IsPaymentRequestEnabled() {

[noyau (Ping after 24h), 2017/07/06 15:33:28]

Can you get rid of this function and use IsEnabled directly? I'd like to get rid
of this whole file ultimately.

[Mathieu, 2017/07/06 15:34:30]

Done!

-  // This call activates the field trial, if needed, so it must come before any
-  // early returns.
-  std::string group_name =
-      base::FieldTrialList::FindFullName("IOSPaymentRequest");
-
-  // Check if the experimental flag is forced on or off.
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  if (command_line->HasSwitch(switches::kEnablePaymentRequest)) {
-    return true;
-  } else if (command_line->HasSwitch(switches::kDisablePaymentRequest)) {
-    return false;
-  }
-
-  // Check if the Finch experiment is turned on.
-  return base::StartsWith(group_name, "Enabled",
-                          base::CompareCase::INSENSITIVE_ASCII);
+  return base::FeatureList::IsEnabled(payments::features::kWebPayments);
 }
 
 bool IsPhysicalWebEnabled() {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kEnableIOSPhysicalWeb)) {
     return true;
   } else if (command_line->HasSwitch(switches::kDisableIOSPhysicalWeb)) {
     return false;
   }
 
@@ skipping 115 matching lines @@
   } else if (command_line->HasSwitch(
                  switches::kDisableThirdPartyKeyboardWorkaround)) {
     return false;
   }
 
   // Check if the Finch experiment is turned on.
   return base::FeatureList::IsEnabled(kEnableThirdPartyKeyboardWorkaround);
 }
 
 }  // namespace experimental_flags