Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2966893002: Revert of Simplify condition to use libc++ (Closed)

Created:
3 years, 5 months ago by findit-for-me
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify condition to use libc++ (patchset #2 id:20001 of https://codereview.chromium.org/2963183003/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 483787 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNiNTE1MjUzOGQxMzNmNTlhYTY3MDlhMDgxMWZmNmM3NDU5NzNjYzYM Original issue's description: > Simplify condition to use libc++ > > This CL simplifies use_custom_libcxx. Most of the sanitizers are only > used on Linux so those cases can be removed. > > BUG=593874 > R=thakis@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > Review-Url: https://codereview.chromium.org/2963183003 > Cr-Commit-Position: refs/heads/master@{#483787} > Committed: https://chromium.googlesource.com/chromium/src/+/3b5152538d133f59aa6709a0811ff6c745973cc6 TBR=thakis@chromium.org,thomasanderson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593874 Review-Url: https://codereview.chromium.org/2966893002 Cr-Commit-Position: refs/heads/master@{#483814} Committed: https://chromium.googlesource.com/chromium/src/+/d667444e9a52506535575a508d35dd9cede6d49b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M build/config/c++/c++.gni View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
findit-for-me
Created Revert of Simplify condition to use libc++
3 years, 5 months ago (2017-06-30 21:08:05 UTC) #1
findit-for-me
Sheriffs, CL owner or CL reviewers: Please confirm and "Quick L-G-T-M & CQ" this revert ...
3 years, 5 months ago (2017-06-30 21:08:06 UTC) #3
Tom Anderson
lgtm
3 years, 5 months ago (2017-06-30 21:13:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966893002/1
3 years, 5 months ago (2017-06-30 21:13:38 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 21:14:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d667444e9a52506535575a508d35...

Powered by Google App Engine
This is Rietveld 408576698