Chromium Code Reviews
DescriptionRevert of Simplify condition to use libc++ (patchset #2 id:20001 of https://codereview.chromium.org/2963183003/ )
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 483787 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNiNTE1MjUzOGQxMzNmNTlhYTY3MDlhMDgxMWZmNmM3NDU5NzNjYzYM
Original issue's description:
> Simplify condition to use libc++
>
> This CL simplifies use_custom_libcxx. Most of the sanitizers are only
> used on Linux so those cases can be removed.
>
> BUG=593874
> R=thakis@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
>
> Review-Url: https://codereview.chromium.org/2963183003
> Cr-Commit-Position: refs/heads/master@{#483787}
> Committed: https://chromium.googlesource.com/chromium/src/+/3b5152538d133f59aa6709a0811ff6c745973cc6
TBR=thakis@chromium.org,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593874
Review-Url: https://codereview.chromium.org/2966893002
Cr-Commit-Position: refs/heads/master@{#483814}
Committed: https://chromium.googlesource.com/chromium/src/+/d667444e9a52506535575a508d35dd9cede6d49b
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
|||||||||||||||||||