Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: build/config/c++/c++.gni

Issue 2966893002: Revert of Simplify condition to use libc++ (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/c++/c++.gni
diff --git a/build/config/c++/c++.gni b/build/config/c++/c++.gni
index eca1b2cdd02fc1299744b0136ca43a003c9fe56a..5a62670afafef626d726682de03ba524f2a956c3 100644
--- a/build/config/c++/c++.gni
+++ b/build/config/c++/c++.gni
@@ -4,10 +4,20 @@
import("//build/config/sanitizers/sanitizers.gni")
+if (current_toolchain != default_toolchain) {
+ use_custom_libcxx = false
+}
+
declare_args() {
# Use libc++ (buildtools/third_party/libc++ and
# buildtools/third_party/libc++abi) instead of stdlibc++ as standard
# library.
+ # TODO(thomasanderson): Clean up this complex condition. The
+ # is_tsan, is_msan, and (use_libfuzzer && !is_mac), clauses can be
+ # removed since they are only used on non-CrOs Linux. is_ubsan can
+ # probably also be removed for the same reason.
use_custom_libcxx =
- is_linux && !is_chromeos && (!is_chromecast || is_cast_desktop_build)
+ (is_linux && !is_chromeos && (!is_chromecast || is_cast_desktop_build)) ||
+ is_tsan || is_msan || is_ubsan || is_ubsan_security ||
+ (use_libfuzzer && !is_mac) || use_afl
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698