Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2966863002: [LayoutNG] Add floats_bfc_offset to constraint space. (Closed)

Created:
3 years, 5 months ago by ikilpatrick
Modified:
3 years, 5 months ago
Reviewers:
cbiesinger, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, lchoi+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add floats_bfc_offset to constraint space. This is in preparation for the new float handling behaviour, in patch: https://codereview.chromium.org/2954953002/ BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2966863002 Cr-Commit-Position: refs/heads/master@{#483812} Committed: https://chromium.googlesource.com/chromium/src/+/ef23377b7e6dc4067596b3ae607b31e2b6ee0582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 4 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc View 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ikilpatrick
3 years, 5 months ago (2017-06-30 18:48:57 UTC) #4
eae
LGTM Love the detailed comments in there, thank you!
3 years, 5 months ago (2017-06-30 18:50:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966863002/1
3 years, 5 months ago (2017-06-30 19:12:55 UTC) #9
cbiesinger
lgtm
3 years, 5 months ago (2017-06-30 20:28:04 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 20:47:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef23377b7e6dc4067596b3ae607b...

Powered by Google App Engine
This is Rietveld 408576698