third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h - Issue 2966863002: [LayoutNG] Add floats_bfc_offset to constraint space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2966863002: [LayoutNG] Add floats_bfc_offset to constraint space. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

index bfe179aff48c3fc9323c6ade83418d58917a310c..60006fdf687f0fdd1ba9f7350c2840e85b9ebb43 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

@@ -53,7 +53,9 @@ class CORE_EXPORT NGConstraintSpaceBuilder final {

NGConstraintSpaceBuilder& SetMarginStrut(const NGMarginStrut& margin_strut);

- NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& offset);

+ NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& bfc_offset);

+ NGConstraintSpaceBuilder& SetFloatsBfcOffset(

+ const WTF::Optional<NGLogicalOffset>& floats_bfc_offset);

NGConstraintSpaceBuilder& SetClearanceOffset(

const WTF::Optional<LayoutUnit>& clearance_offset);

@@ -89,6 +91,7 @@ class CORE_EXPORT NGConstraintSpaceBuilder final {

NGMarginStrut margin_strut_;

NGLogicalOffset bfc_offset_;

+ WTF::Optional<NGLogicalOffset> floats_bfc_offset_;

std::shared_ptr<NGExclusions> exclusions_;

WTF::Optional<LayoutUnit> clearance_offset_;

Vector<RefPtr<NGUnpositionedFloat>> unpositioned_floats_;