Add ripple effect to action in expand button.

Add ripple effect to action in expand button.

In new-style notification, click inside the expand button in the header
could not trigger ripple effect animation. This CL forwards mouse and
key events to NotificationHeaderView.
The CL also disables ripple effect when the expand button is disabled.

BUG=736996
TEST=manual

Review-Url: https://codereview.chromium.org/2966673002
Cr-Commit-Position: refs/heads/master@{#484045}
Committed: https://chromium.googlesource.com/chromium/src/+/984a15c405577aff40ac40636b010231c1009f33

[tetsui, 2017-06-30 04:21:26]

tetsui@chromium.org changed reviewers:
+ fukino@chromium.org, yoshiki@chromium.org

[tetsui, 2017-06-30 04:21:27]

Please take a look. Thanks!

[tetsui, 2017-06-30 04:22:04]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 04:22:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 05:23:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 05:23:37]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-07-03 06:15:47]

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_header_view.h (right):

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_header_view.h:21: class ExpandButton;
We should avoid forward declaring a methods in  anonymous namespace. Could you
make it a child-class of NotificationHeaderView, or make it non-friend?

[yoshiki, 2017-07-03 06:26:49]

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_header_view.cc (right):

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_header_view.cc:46: class ExpandButton :
public views::ImageButton, public views::ButtonListener {
BTW, why is it inheriting a button? Although this doesn't accept mouse event and
key events, is it necessary to be a button?

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_header_view.cc:81: views::View* source =
this;
Can this method be empty? I think if you don't anything in this method, the
event will propagate to the parent view (in this case, header view)
automatically.

[tetsui, 2017-07-03 07:10:54]

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_header_view.cc (right):

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_header_view.cc:46: class ExpandButton :
public views::ImageButton, public views::ButtonListener {
On 2017/07/03 06:26:49, yoshiki wrote:
> BTW, why is it inheriting a button? Although this doesn't accept mouse event
and
> key events, is it necessary to be a button?

Done.

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_header_view.cc:81: views::View* source =
this;
On 2017/07/03 06:26:49, yoshiki wrote:
> Can this method be empty? I think if you don't anything in this method, the
> event will propagate to the parent view (in this case, header view)
> automatically.

Done.

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_header_view.h (right):

https://codereview.chromium.org/2966673002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_header_view.h:21: class ExpandButton;
On 2017/07/03 06:15:47, yoshiki wrote:
> We should avoid forward declaring a methods in  anonymous namespace. Could you
> make it a child-class of NotificationHeaderView, or make it non-friend?

Done.

[tetsui, 2017-07-03 07:11:01]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 07:11:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 07:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 07:46:09]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tetsui, 2017-07-03 07:48:05]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 07:48:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 08:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 08:46:03]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-07-04 02:06:22]

lgtm

[tetsui, 2017-07-04 02:07:21]

Thank you for the reviewing!

[tetsui, 2017-07-04 02:07:35]

The CQ bit was checked by tetsui@chromium.org

[commit-bot: I haz the power, 2017-07-04 02:07:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 03:11:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499134055838650,
"parent_rev": "348042eccc554005afd6ec73bad857493c42c4e7", "commit_rev":
"984a15c405577aff40ac40636b010231c1009f33"}

[commit-bot: I haz the power, 2017-07-04 03:11:29]

Description was changed from

==========
Add ripple effect to action in expand button.

In new-style notification, click inside the expand button in the header
could not trigger ripple effect animation. This CL forwards mouse and
key events to NotificationHeaderView.
The CL also disables ripple effect when the expand button is disabled.

BUG=736996
TEST=manual
==========

to

==========
Add ripple effect to action in expand button.

In new-style notification, click inside the expand button in the header
could not trigger ripple effect animation. This CL forwards mouse and
key events to NotificationHeaderView.
The CL also disables ripple effect when the expand button is disabled.

BUG=736996
TEST=manual

Review-Url: https://codereview.chromium.org/2966673002
Cr-Commit-Position: refs/heads/master@{#484045}
Committed:
https://chromium.googlesource.com/chromium/src/+/984a15c405577aff40ac40636b01...
==========

[commit-bot: I haz the power, 2017-07-04 03:11:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/984a15c405577aff40ac40636b01...