Add ripple effect to action in expand button.

ui/message_center/views/notification_header_view.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/views/notification_header_view.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/color_palette.h"
@@ skipping 25 matching lines @@
 // Bullet character. The divider symbol between different parts of the header.
 constexpr base::char16 kNotificationHeaderDividerSymbol = 0x2022;
 
 // Base ink drop color of action buttons.
 const SkColor kInkDropBaseColor = SkColorSetRGB(0x0, 0x0, 0x0);
 // Ripple ink drop opacity of action buttons.
 constexpr float kInkDropRippleVisibleOpacity = 0.08f;
 // Highlight (hover) ink drop opacity of action buttons.
 constexpr float kInkDropHighlightVisibleOpacity = 0.08f;
 
+class ExpandButton : public views::ImageButton, public views::ButtonListener {

[yoshiki, 2017/07/03 06:26:49]

BTW, why is it inheriting a button? Although this doesn't accept mouse event and
key events, is it necessary to be a button?

[tetsui, 2017/07/03 07:10:54]

Done.

+ public:
+  ExpandButton(NotificationHeaderView* header);
+  ~ExpandButton() override;
+
+  // ButtonListener override:
+  void ButtonPressed(Button* sender, const ui::Event& event) override;
+
+ protected:
+  // ImageButton override:
+  void OnMouseEvent(ui::MouseEvent* event) override;
+  void OnKeyEvent(ui::KeyEvent* event) override;
+
+ private:
+  NotificationHeaderView* header_;
+};
+
+ExpandButton::ExpandButton(NotificationHeaderView* header)
+    : views::ImageButton(this), header_(header) {
+  SetImage(views::Button::STATE_NORMAL,
+           gfx::CreateVectorIcon(kNotificationExpandMoreIcon, kExpandIconSize,
+                                 gfx::kChromeIconGrey));
+  SetFocusForPlatform();
+  SetFocusPainter(views::Painter::CreateSolidFocusPainter(
+      kFocusBorderColor, gfx::Insets(1, 2, 2, 2)));
+}
+
+ExpandButton::~ExpandButton() = default;
+
+void ExpandButton::ButtonPressed(Button* sender, const ui::Event& event) {
+  // No need to handle event here because raw OnMouseEvent and OnKeyEvent are
+  // forwarded to NotificationHeaderView.
+}
+
+void ExpandButton::OnMouseEvent(ui::MouseEvent* event) {
+  views::View* source = this;

[yoshiki, 2017/07/03 06:26:49]

Can this method be empty? I think if you don't anything in this method, the
event will propagate to the parent view (in this case, header view)
automatically.

[tetsui, 2017/07/03 07:10:54]

Done.

+  views::View* target = header_;
+  ui::MouseEvent converted_event(*event, source, target);
+  header_->OnMouseEvent(&converted_event);
+}
+
+void ExpandButton::OnKeyEvent(ui::KeyEvent* event) {
+  header_->OnKeyEvent(event);
+}
+
 }  // namespace
 
 NotificationHeaderView::NotificationHeaderView(views::ButtonListener* listener)
     : views::CustomButton(listener) {
   SetInkDropMode(InkDropMode::ON);
   set_has_ink_drop_action_on_click(true);
   set_animate_on_state_change(true);
   set_notify_enter_exit_on_child(true);
   set_ink_drop_base_color(kInkDropBaseColor);
   set_ink_drop_visible_opacity(kInkDropRippleVisibleOpacity);
@@ skipping 38 matching lines @@
   app_info_container->AddChildView(summary_text_divider_);
 
   // Summary text view
   summary_text_view_ = new views::Label(base::string16());
   summary_text_view_->SetFontList(font_list);
   summary_text_view_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   summary_text_view_->SetVisible(false);
   app_info_container->AddChildView(summary_text_view_);
 
   // Expand button view
-  expand_button_ = new views::ImageButton(listener);
-  expand_button_->SetImage(
-      views::Button::STATE_NORMAL,
-      gfx::CreateVectorIcon(kNotificationExpandMoreIcon, kExpandIconSize,
-                            gfx::kChromeIconGrey));
-  expand_button_->SetFocusForPlatform();
-  expand_button_->SetFocusPainter(views::Painter::CreateSolidFocusPainter(
-      kFocusBorderColor, gfx::Insets(1, 2, 2, 2)));
+  expand_button_ = new ExpandButton(this);
   app_info_container->AddChildView(expand_button_);
 
   // Spacer between left-aligned views and right-aligned views
   views::View* spacer = new views::View;
   spacer->SetPreferredSize(gfx::Size(1, kHeaderHeight));
   AddChildView(spacer);
   layout->SetFlexForView(spacer, 1);
 
   // Settings button view
   settings_button_ = new PaddedButton(listener);
@@ skipping 28 matching lines @@
   has_summary_text_ = true;
   UpdateSummaryTextVisibility();
 }
 
 void NotificationHeaderView::ClearProgress() {
   has_summary_text_ = false;
   UpdateSummaryTextVisibility();
 }
 
 void NotificationHeaderView::SetExpandButtonEnabled(bool enabled) {
+  // SetInkDropMode iff. the visibility changed.
+  // Otherwise, the ink drop animation cannot finish.
+  if (expand_button_->visible() != enabled)
+    SetInkDropMode(enabled ? InkDropMode::ON : InkDropMode::OFF);
+
   expand_button_->SetVisible(enabled);
 }
 
 void NotificationHeaderView::SetExpanded(bool expanded) {
   expand_button_->SetImage(
       views::Button::STATE_NORMAL,
       gfx::CreateVectorIcon(
           expanded ? kNotificationExpandLessIcon : kNotificationExpandMoreIcon,
           kExpandIconSize, gfx::kChromeIconGrey));
 }
@@ skipping 63 matching lines @@
   Layout();
 }
 
 void NotificationHeaderView::UpdateSummaryTextVisibility() {
   summary_text_divider_->SetVisible(has_summary_text_);
   summary_text_view_->SetVisible(has_summary_text_);
   Layout();
 }
 
 }  // namespace message_center