Stop Nesting Test Suites in mash_browser_tests

Stop Nesting Test Suites in mash_browser_tests

MojoTestState registers content_package_services as a service of the
BackgroundServiceManager.

MojoTestConnector::ServiceProcessLauncherDelegateImpl::AdjustCommandLineArgumentsForTarget
eventually handles a request to launch the content_package_services.

This leads to RunMashBrowserTests relaunching the test suite, as a child of the
original suite. This time with a mixed state of a local-Ash and non-local-Aura.

This causes OzonePlatform to crash, and the test suite to have a long run time.

This patch updates RunMashBrowserTests to not act when asked to launch
content_package_services. Follow up changes will find the source, and setup an
appropriate launch mechanism within RunMashBrowserTests.

TEST=mash_browser_tests
BUG=738449
Review-Url: https://codereview.chromium.org/2966563005
Cr-Commit-Position: refs/heads/master@{#484259}
Committed: https://chromium.googlesource.com/chromium/src/+/08d64457d9385f3f976ba57108a6fe1946b90029

[jonross, 2017-06-30 17:56:36]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-06-30 17:56:37]

Hey sky@,

Could you take a look at this review?

In it I am disabling the relaunch of the mash_browser_tests with
content_package_services. This has been leading to a nesting of tests, as well
as crashes.

PTAL
-Jon

[jonross, 2017-07-04 14:14:23]

jonross@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[jonross, 2017-07-04 14:14:24]

Hey phajdan.jr@,

With sky@ OOO could you provide an owners review of this change?

I'm updating the mash_browser_tests to disable a code path that is currently
causing the test suite to nest runs of itself. This should fix a series of
crashes, while giving me time to investigate the appropriate way to handle
launching this service.

Thanks,
Jon

[Paweł Hajdan Jr., 2017-07-05 08:16:11]

LGTM

[jonross, 2017-07-05 13:08:25]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-07-05 13:08:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 13:37:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499260105249050, "parent_rev":
"09751a027a8fe6cb820998d84170002f5b684ee6", "commit_rev":
"08d64457d9385f3f976ba57108a6fe1946b90029"}

[commit-bot: I haz the power, 2017-07-05 13:38:03]

Description was changed from

==========
Stop Nesting Test Suites in mash_browser_tests

MojoTestState registers content_package_services as a service of the
BackgroundServiceManager.

MojoTestConnector::ServiceProcessLauncherDelegateImpl::AdjustCommandLineArgumentsForTarget
eventually handles a request to launch the content_package_services.

This leads to RunMashBrowserTests relaunching the test suite, as a child of the
original suite. This time with a mixed state of a local-Ash and non-local-Aura.

This causes OzonePlatform to crash, and the test suite to have a long run time.

This patch updates RunMashBrowserTests to not act when asked to launch
content_package_services. Follow up changes will find the source, and setup an
appropriate launch mechanism within RunMashBrowserTests.

TEST=mash_browser_tests
BUG=738449
==========

to

==========
Stop Nesting Test Suites in mash_browser_tests

MojoTestState registers content_package_services as a service of the
BackgroundServiceManager.

MojoTestConnector::ServiceProcessLauncherDelegateImpl::AdjustCommandLineArgumentsForTarget
eventually handles a request to launch the content_package_services.

This leads to RunMashBrowserTests relaunching the test suite, as a child of the
original suite. This time with a mixed state of a local-Ash and non-local-Aura.

This causes OzonePlatform to crash, and the test suite to have a long run time.

This patch updates RunMashBrowserTests to not act when asked to launch
content_package_services. Follow up changes will find the source, and setup an
appropriate launch mechanism within RunMashBrowserTests.

TEST=mash_browser_tests
BUG=738449

Review-Url: https://codereview.chromium.org/2966563005
Cr-Commit-Position: refs/heads/master@{#484259}
Committed:
https://chromium.googlesource.com/chromium/src/+/08d64457d9385f3f976ba57108a6...
==========

[commit-bot: I haz the power, 2017-07-05 13:38:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08d64457d9385f3f976ba57108a6...