Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3915)

Unified Diff: chrome/test/base/mash_browser_tests_main.cc

Issue 2966563005: Stop Nesting Test Suites in mash_browser_tests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/mash_browser_tests_main.cc
diff --git a/chrome/test/base/mash_browser_tests_main.cc b/chrome/test/base/mash_browser_tests_main.cc
index aca66ca71956c8d6cdcb1e1ad3bdaa1abed95b05..8d6f041effa464f0c52cdbb21398849227fe3fe0 100644
--- a/chrome/test/base/mash_browser_tests_main.cc
+++ b/chrome/test/base/mash_browser_tests_main.cc
@@ -27,6 +27,7 @@
#include "chrome/test/base/mojo_test_connector.h"
#include "content/public/app/content_main.h"
#include "content/public/common/service_manager_connection.h"
+#include "content/public/common/service_names.mojom.h"
#include "content/public/test/test_launcher.h"
#include "mash/session/public/interfaces/constants.mojom.h"
#include "services/service_manager/public/cpp/connector.h"
@@ -177,6 +178,20 @@ bool RunMashBrowserTests(int argc, char** argv, int* exit_code) {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
if (!command_line->HasSwitch("run-in-mash") &&
!command_line->HasSwitch("run-in-mus")) {
+ // Currently launching content_package_services via the browser_tests binary
+ // will lead to a nested test suite, trying to run all tests again. However
+ // they will be in a strange mixed mode, of a local-Ash, but non-local Aura.
+ //
+ // This leads to continuous crashes in OzonePlatform.
+ //
+ // For now disable this launch until the requesting site can be identified.
+ //
+ // TODO(jonross): find an appropriate way to launch content_package_services
+ // within the mash_browser_tests (crbug.com/738449)
+ if (command_line->GetSwitchValueASCII("service-name") ==
+ content::mojom::kPackagedServicesServiceName) {
+ return true;
+ }
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698