StabilityReport proto changes for multi-process support

StabilityReport multi-process collection support

Introduces multi-process collection support. Note that multi-processing recording was introduced in https://codereview.chromium.org/2680123003.

Details:
- processes now have a process type and key-value data.
- modules are now attributed to a process
- now collecting all processes, not just the first
- some key-value data (version information, timestamp) remains at report scope, to simplify report parsing

BUG=691595
Review-Url: https://codereview.chromium.org/2966563004
Cr-Commit-Position: refs/heads/master@{#495306}
Committed: https://chromium.googlesource.com/chromium/src/+/27f4805ad79030129eaa9f2e5fa5cf1f8b77393f

[manzagop (departed), 2017-06-30 15:36:07]

manzagop@chromium.org changed reviewers:
+ bcwhite@chromium.org, mmandlis@chromium.org

[manzagop (departed), 2017-06-30 15:36:07]

As per email discussion. PTAL.
Pierre-Antoine

[bcwhite, 2017-06-30 16:40:55]

https://codereview.chromium.org/2966563004/diff/1/components/browser_watcher/...
File components/browser_watcher/stability_report.proto (right):

https://codereview.chromium.org/2966563004/diff/1/components/browser_watcher/...
components/browser_watcher/stability_report.proto:191: map<string, TypedValue>
data = 5;
Can the name be more descriptive?  Or at least a comment?  Relationship to
deprecated "global_data"?

[manzagop (departed), 2017-06-30 20:22:46]

manzagop@chromium.org changed reviewers:
+ ivanpe@chromium.org

[manzagop (departed), 2017-06-30 20:22:47]

https://codereview.chromium.org/2966563004/diff/1/components/browser_watcher/...
File components/browser_watcher/stability_report.proto (right):

https://codereview.chromium.org/2966563004/diff/1/components/browser_watcher/...
components/browser_watcher/stability_report.proto:191: map<string, TypedValue>
data = 5;
On 2017/06/30 16:40:54, bcwhite wrote:
> Can the name be more descriptive?  Or at least a comment?  Relationship to
> deprecated "global_data"?

Revised comments, here and below.

[bcwhite, 2017-06-30 20:50:51]

lgtm

[manzagop (departed), 2017-06-30 20:56:47]

Thanks for the review! 

I'll wait a bit before submitting this, and possibly bundle more changes with
it. I wanted to give an early concrete look into what the changes would look
like int terms of the proto.

[manzagop (departed), 2017-07-28 19:18:32]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-28 19:18:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-07-28 19:25:50]

Description was changed from

==========
StabilityReport proto changes for multi-process support

The first in a series of changes to enable multi process support for
collection. Support for recording was introduced in
https://codereview.chromium.org/2680123003

BUG=691595
==========

to

==========
StabilityReport multi-process collection support

Introduces multi-process collection support. Note that multi-processing
recording was introduced in https://codereview.chromium.org/2680123003.

Details:
- processes now have a process type and key-value data.
- modules are now attributed to a process
- now collecting all processes, not just the first
- some key-value data (version information, timestamp) remains at report scope,
to simplify report parsing

BUG=691595
==========

[commit-bot: I haz the power, 2017-07-28 19:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 19:27:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[manzagop (departed), 2017-07-28 19:40:59]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-28 19:41:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-07-28 19:50:48]

Hi Brian,
I added the changes to fill the proto. Another look?
Thanks!
Pierre

[commit-bot: I haz the power, 2017-07-28 20:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 20:24:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chromium-reviews, 2017-07-31 13:55:45]

LGTM
(my phone with Authenticator died while away and my rescue codes are locked
away in Montreal)

On Fri, Jul 28, 2017 at 3:50 PM, <manzagop@chromium.org> wrote:

> Hi Brian,
> I added the changes to fill the proto. Another look?
> Thanks!
> Pierre
>
> https://codereview.chromium.org/2966563004/
>



-- 
  Brian
  bcwhite@google.com
-----------------------------------------------------------------------------------------



*Treat someone as they are and they will remain that way.Treat someone as
they can be and they will become that way.*

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[manzagop (departed), 2017-08-04 19:37:53]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-04 19:37:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-04 20:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-04 20:12:49]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[manzagop (departed), 2017-08-05 15:11:52]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-05 15:11:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-05 15:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-05 15:19:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[manzagop (departed), 2017-08-05 15:45:56]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-05 15:46:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-05 15:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-05 15:53:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[manzagop (departed), 2017-08-05 16:04:54]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-05 16:04:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-05 16:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-05 16:12:28]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[manzagop (departed), 2017-08-05 16:39:39]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-05 16:39:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-08-05 16:40:45]

Patchset #7 (id:120001) has been deleted

[manzagop (departed), 2017-08-05 16:40:56]

Patchset #7 (id:140001) has been deleted

[manzagop (departed), 2017-08-05 16:41:04]

Patchset #7 (id:160001) has been deleted

[manzagop (departed), 2017-08-05 16:43:30]

The tests were failing because modules are filtered based on analysis_stamp_
which is set via GetFirstProcess. I revised the contract to state the
expectation that GetFirstProcess must be called. Another look?

[manzagop (departed), 2017-08-05 16:44:33]

manzagop@chromium.org changed reviewers:
+ jwd@chromium.org

[manzagop (departed), 2017-08-05 16:44:34]

Hi Jesse,

Could you have an owner's look at:
chrome\browser\chrome_browser_field_trials_desktop.cc

Thanks!

Pierre-Antoine

[commit-bot: I haz the power, 2017-08-05 18:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-05 18:06:39]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2017-08-17 18:27:55]

Friendly ping Jesse. :)

[manzagop (departed), 2017-08-17 18:39:50]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-17 18:39:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jwd, 2017-08-17 18:42:05]

lgtm

[manzagop (departed), 2017-08-17 20:09:12]

Thanks!

[commit-bot: I haz the power, 2017-08-17 20:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-17 20:22:34]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2017-08-17 20:26:16]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-08-17 20:26:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org
Link to the patchset: https://codereview.chromium.org/2966563004/#ps200001
(title: "Merge")

[commit-bot: I haz the power, 2017-08-17 20:26:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-17 20:32:15]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1503001576725110,
"parent_rev": "25f8e45097c78da4357826bf2b4d3b9f281eef25", "commit_rev":
"27f4805ad79030129eaa9f2e5fa5cf1f8b77393f"}

[commit-bot: I haz the power, 2017-08-17 20:32:41]

Description was changed from

==========
StabilityReport multi-process collection support

Introduces multi-process collection support. Note that multi-processing
recording was introduced in https://codereview.chromium.org/2680123003.

Details:
- processes now have a process type and key-value data.
- modules are now attributed to a process
- now collecting all processes, not just the first
- some key-value data (version information, timestamp) remains at report scope,
to simplify report parsing

BUG=691595
==========

to

==========
StabilityReport multi-process collection support

Introduces multi-process collection support. Note that multi-processing
recording was introduced in https://codereview.chromium.org/2680123003.

Details:
- processes now have a process type and key-value data.
- modules are now attributed to a process
- now collecting all processes, not just the first
- some key-value data (version information, timestamp) remains at report scope,
to simplify report parsing

BUG=691595

Review-Url: https://codereview.chromium.org/2966563004
Cr-Commit-Position: refs/heads/master@{#495306}
Committed:
https://chromium.googlesource.com/chromium/src/+/27f4805ad79030129eaa9f2e5fa5...
==========

[commit-bot: I haz the power, 2017-08-17 20:32:43]

Committed patchset #8 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/27f4805ad79030129eaa9f2e5fa5...