Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: components/browser_watcher/dump_stability_report_main_win.cc

Issue 2966563004: StabilityReport proto changes for multi-process support (Closed)
Patch Set: Merge Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/dump_stability_report_main_win.cc
diff --git a/components/browser_watcher/dump_stability_report_main_win.cc b/components/browser_watcher/dump_stability_report_main_win.cc
index 903677dd5376e035f6ac28a80c9707b2008b4331..bc3940ad8a09c0b183ae2d7f0c2a742bea6c5550 100644
--- a/components/browser_watcher/dump_stability_report_main_win.cc
+++ b/components/browser_watcher/dump_stability_report_main_win.cc
@@ -140,8 +140,25 @@ void PrintActivity(FILE* out,
void PrintProcessState(FILE* out,
const browser_watcher::ProcessState& process) {
- fprintf(out, "Process %lld (%d threads)\n", process.process_id(),
- process.threads_size());
+ std::string process_type;
+ switch (process.process_type()) {
+ case browser_watcher::ProcessState::UNKNOWN_PROCESS:
+ process_type = "unknown type";
+ break;
+ case browser_watcher::ProcessState::BROWSER_PROCESS:
+ process_type = "browser";
+ break;
+ case browser_watcher::ProcessState::WATCHER_PROCESS:
+ process_type = "watcher";
+ break;
+ default:
+ base::SStringPrintf(&process_type, "process type %d",
+ process.process_type());
+ break;
+ }
+
+ fprintf(out, "Process %lld (%s, %d threads)\n", process.process_id(),
+ process_type.c_str(), process.threads_size());
if (process.has_memory_state() &&
process.memory_state().has_windows_memory()) {
@@ -163,12 +180,15 @@ void PrintProcessState(FILE* out,
windows_memory.process_allocation_attempt());
}
}
+
for (const browser_watcher::ThreadState& thread : process.threads()) {
fprintf(out, "Thread %lld (%s) : %d activities\n", thread.thread_id(),
thread.thread_name().c_str(), thread.activity_count());
for (const browser_watcher::Activity& activity : thread.activities())
PrintActivity(out, 1, activity);
}
+
+ PrintUserData(out, 1, process.data());
}
// TODO(manzagop): flesh out as StabilityReport gets fleshed out.
« no previous file with comments | « chrome/browser/chrome_browser_field_trials_desktop.cc ('k') | components/browser_watcher/stability_data_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698