Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 2966163003: CrOS files app: Stop using <paper-dialog>, use plain <dialog> instead. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, fukino+watch_chromium.org, mtomasz+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, yamaguchi+watch_chromium.org, oka
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS files app: Stop using <paper-dialog>, use plain <dialog> instead. BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2966163003 Cr-Commit-Position: refs/heads/master@{#484634} Committed: https://chromium.googlesource.com/chromium/src/+/7c1793f8422af75eba7e3fc7170d15423e809675

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.css View 1 chunk +13 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.js View 1 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dpapad
Before/after http://imgur.com/a/IGLRY.
3 years, 5 months ago (2017-07-05 21:21:23 UTC) #5
fukino
lgtm. Thank you!
3 years, 5 months ago (2017-07-06 04:00:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966163003/20001
3 years, 5 months ago (2017-07-06 16:39:03 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 16:44:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c1793f8422af75eba7e3fc7170d...

Powered by Google App Engine
This is Rietveld 408576698