Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_quick_view.js

Issue 2966163003: CrOS files app: Stop using <paper-dialog>, use plain <dialog> instead. (Closed)
Patch Set: fix typo Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/elements/files_quick_view.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/elements/files_quick_view.js
diff --git a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
index a3096bbfcce60fb70e11b4df662bb22187c599df..d7099154fb3d8aa7502ed2daa5a600dc32cd7d70 100644
--- a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
+++ b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
@@ -51,10 +51,15 @@ var FilesQuickView = Polymer({
this.browsable = false;
},
+ /** @return {boolean} */
+ isOpened: function() {
+ return this.$.dialog.open;
+ },
+
// Opens the dialog.
open: function() {
if (!this.isOpened())
- this.$.dialog.open();
+ this.$.dialog.showModal();
},
// Closes the dialog.
@@ -63,15 +68,6 @@ var FilesQuickView = Polymer({
this.$.dialog.close();
},
- /**
- * @return {boolean}
- */
- isOpened: function() {
- // TODO(oka): This is a workaround to satisfy closure compiler.
- // Update ['opened'] to .opened.
- return (/** @type{Object} */ (this.$.dialog))['opened'];
- },
-
/**
* @return {!FilesMetadataBox}
*/
« no previous file with comments | « ui/file_manager/file_manager/foreground/elements/files_quick_view.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698