Chromium Code Reviews
DescriptionReland of Use shared NotificationControlButtonsView for non-arc notification buttons (patchset #1 id:1 of https://codereview.chromium.org/2970953002/ )
Reason for revert:
Let me reland this CL. This should break the ASAN but the fix is ready and I'll commit it soon after this.
Fix CL: https://codereview.chromium.org/2967133002/
Original issue's description:
> Revert of Use shared NotificationControlButtonsView for non-arc notification buttons (patchset #3 id:60001 of https://codereview.chromium.org/2964973002/ )
>
> Reason for revert:
> Reverting, as this patch caused numerous leaks (see https://bugs.chromium.org/p/chromium/issues/detail?id=739356)
>
> Original issue's description:
> > Use shared NotificationControlButtonsView for non-arc notification buttons
> >
> > We recently introduced NotificationControlButtonsView for displaying control buttons. ARC notification already uses it. This CL makes non-ARC notifications use it.
> >
> > BUG=717455
> > TEST=unittest passes
> >
> > Review-Url: https://codereview.chromium.org/2964973002
> > Cr-Commit-Position: refs/heads/master@{#484219}
> > Committed: https://chromium.googlesource.com/chromium/src/+/12cad72cd90108551c79ebde78ed564832478707
>
> TBR=yhanada@chromium.org,yoshiki@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=717455
>
> Review-Url: https://codereview.chromium.org/2970953002
> Cr-Commit-Position: refs/heads/master@{#484255}
> Committed: https://chromium.googlesource.com/chromium/src/+/5f296638b446e73d14fb90901448cf117d03669c
TBR=yhanada@chromium.org,glider@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717455
Review-Url: https://codereview.chromium.org/2966063003
Cr-Commit-Position: refs/heads/master@{#484261}
Committed: https://chromium.googlesource.com/chromium/src/+/37f1fcbb6e58b5414e2fa310e3a26dea0865656e
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||