Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2966063003: Reland of Use shared NotificationControlButtonsView for non-arc notification buttons (Closed)

Created:
3 years, 5 months ago by yoshiki
Modified:
3 years, 5 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use shared NotificationControlButtonsView for non-arc notification buttons (patchset #1 id:1 of https://codereview.chromium.org/2970953002/ ) Reason for revert: Let me reland this CL. This should break the ASAN but the fix is ready and I'll commit it soon after this. Fix CL: https://codereview.chromium.org/2967133002/ Original issue's description: > Revert of Use shared NotificationControlButtonsView for non-arc notification buttons (patchset #3 id:60001 of https://codereview.chromium.org/2964973002/ ) > > Reason for revert: > Reverting, as this patch caused numerous leaks (see https://bugs.chromium.org/p/chromium/issues/detail?id=739356) > > Original issue's description: > > Use shared NotificationControlButtonsView for non-arc notification buttons > > > > We recently introduced NotificationControlButtonsView for displaying control buttons. ARC notification already uses it. This CL makes non-ARC notifications use it. > > > > BUG=717455 > > TEST=unittest passes > > > > Review-Url: https://codereview.chromium.org/2964973002 > > Cr-Commit-Position: refs/heads/master@{#484219} > > Committed: https://chromium.googlesource.com/chromium/src/+/12cad72cd90108551c79ebde78ed564832478707 > > TBR=yhanada@chromium.org,yoshiki@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=717455 > > Review-Url: https://codereview.chromium.org/2970953002 > Cr-Commit-Position: refs/heads/master@{#484255} > Committed: https://chromium.googlesource.com/chromium/src/+/5f296638b446e73d14fb90901448cf117d03669c TBR=yhanada@chromium.org,glider@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717455 Review-Url: https://codereview.chromium.org/2966063003 Cr-Commit-Position: refs/heads/master@{#484261} Committed: https://chromium.googlesource.com/chromium/src/+/37f1fcbb6e58b5414e2fa310e3a26dea0865656e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -162 lines) Patch
M ui/message_center/views/notification_control_buttons_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view.h View 5 chunks +4 lines, -10 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 12 chunks +38 lines, -126 lines 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 12 chunks +34 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yoshiki
Created Reland of Use shared NotificationControlButtonsView for non-arc notification buttons
3 years, 5 months ago (2017-07-05 13:45:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966063003/1
3 years, 5 months ago (2017-07-05 13:45:55 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 13:46:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37f1fcbb6e58b5414e2fa310e3a2...

Powered by Google App Engine
This is Rietveld 408576698