Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2964973002:
Use shared NotificationControlButtonsView for non-arc notification buttons (Closed)
DescriptionUse shared NotificationControlButtonsView for non-arc notification buttons
We recently introduced NotificationControlButtonsView for displaying control buttons. ARC notification already uses it. This CL makes non-ARC notifications use it.
BUG=717455
TEST=unittest passes
Review-Url: https://codereview.chromium.org/2964973002
Cr-Commit-Position: refs/heads/master@{#484219}
Committed: https://chromium.googlesource.com/chromium/src/+/12cad72cd90108551c79ebde78ed564832478707
Patch Set 1 #
Total comments: 6
Patch Set 2 : addressed comments #Patch Set 3 : fix test failure #
Messages
Total messages: 28 (20 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== . BUG= ========== to ========== Use shared NotificationControlButtonsView for non-arc notification buttons We recently introduced NotificationControlButtonsView for displaying control buttons. ARC notification already uses it. This CL makes non-ARC notifications use it. BUG=717455 TEST=unittest passes ==========
yoshiki@chromium.org changed reviewers: + yhanada@chromium.org
Hanada-san, PTAL. Thanks.
https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... File ui/message_center/views/notification_view.cc (right): https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... ui/message_center/views/notification_view.cc:475: void NotificationView::CreateOrUpdateSettingsButtonView( Should we rename this method? https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... ui/message_center/views/notification_view.cc:634: void NotificationView::CreateOrUpdateCloseButtonView( ditto https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... File ui/message_center/views/notification_view.h (right): https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... ui/message_center/views/notification_view.h:28: class NotificationControlButtonsView; Don't we need to sort the declarations?
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Hanada-san, PTAL again. https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... File ui/message_center/views/notification_view.cc (right): https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... ui/message_center/views/notification_view.cc:475: void NotificationView::CreateOrUpdateSettingsButtonView( On 2017/07/05 04:40:21, yhanada wrote: > Should we rename this method? Done. I combined two methods. https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... ui/message_center/views/notification_view.cc:634: void NotificationView::CreateOrUpdateCloseButtonView( On 2017/07/05 04:40:21, yhanada wrote: > ditto Done. https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... File ui/message_center/views/notification_view.h (right): https://codereview.chromium.org/2964973002/diff/1/ui/message_center/views/not... ui/message_center/views/notification_view.h:28: class NotificationControlButtonsView; On 2017/07/05 04:40:22, yhanada wrote: > Don't we need to sort the declarations? Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yoshiki@chromium.org
The CQ bit was checked by yoshiki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhanada@chromium.org Link to the patchset: https://codereview.chromium.org/2964973002/#ps60001 (title: "fix test failure")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499241567012830,
"parent_rev": "28c838c598c2e513ac94512f828c4ee43af4e5d6", "commit_rev":
"12cad72cd90108551c79ebde78ed564832478707"}
Message was sent while issue was closed.
Description was changed from ========== Use shared NotificationControlButtonsView for non-arc notification buttons We recently introduced NotificationControlButtonsView for displaying control buttons. ARC notification already uses it. This CL makes non-ARC notifications use it. BUG=717455 TEST=unittest passes ========== to ========== Use shared NotificationControlButtonsView for non-arc notification buttons We recently introduced NotificationControlButtonsView for displaying control buttons. ARC notification already uses it. This CL makes non-ARC notifications use it. BUG=717455 TEST=unittest passes Review-Url: https://codereview.chromium.org/2964973002 Cr-Commit-Position: refs/heads/master@{#484219} Committed: https://chromium.googlesource.com/chromium/src/+/12cad72cd90108551c79ebde78ed... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/12cad72cd90108551c79ebde78ed...
Message was sent while issue was closed.
This commit causes a memory leak. The fix will be committed soon: https://codereview.chromium.org/2967133002/
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2970953002/ by glider@chromium.org. The reason for reverting is: Reverting, as this patch caused numerous leaks (see https://bugs.chromium.org/p/chromium/issues/detail?id=739356). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
