The CQ bit was checked by timloh@chromium.org
Created Revert of file_manager: Migrate FILE thread to TaskScheduler
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1499052294346990, "parent_rev": "0b1e7c8b342d2856dcaa754a7070c4865a01680f", "commit_rev": "062e1f253f540160c760615b36bdefe9385efe74"}
Description was changed from ========== Revert of file_manager: Migrate FILE thread to TaskScheduler (patchset #2 id:60001 of https://codereview.chromium.org/2966713002/ ) Reason for revert: Test FileManagerFileWatcherTest.WatchLocalFile broken on ASAN LSAN and MSAN bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MS... Original issue's description: > file_manager: Migrate FILE thread to TaskScheduler > > BUG=689520 > TEST=new file in Downloads is detected and displayed instantly (file watching is working as before) > > Review-Url: https://codereview.chromium.org/2966713002 > Cr-Commit-Position: refs/heads/master@{#483916} > Committed: https://chromium.googlesource.com/chromium/src/+/28368492d9516e5363810b98a46f... TBR=fukino@chromium.org,satorux@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=689520 ========== to ========== Revert of file_manager: Migrate FILE thread to TaskScheduler (patchset #2 id:60001 of https://codereview.chromium.org/2966713002/ ) Reason for revert: Test FileManagerFileWatcherTest.WatchLocalFile broken on ASAN LSAN and MSAN bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MS... Original issue's description: > file_manager: Migrate FILE thread to TaskScheduler > > BUG=689520 > TEST=new file in Downloads is detected and displayed instantly (file watching is working as before) > > Review-Url: https://codereview.chromium.org/2966713002 > Cr-Commit-Position: refs/heads/master@{#483916} > Committed: https://chromium.googlesource.com/chromium/src/+/28368492d9516e5363810b98a46f... TBR=fukino@chromium.org,satorux@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=689520 Review-Url: https://codereview.chromium.org/2965903002 Cr-Commit-Position: refs/heads/master@{#483936} Committed: https://chromium.googlesource.com/chromium/src/+/062e1f253f540160c760615b36bd... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/062e1f253f540160c760615b36bd...
lgtm. thank you for reverting this. let me test with asan locally.
FWIW, https://codereview.chromium.org/2970653002/ is a patch for relanding with a fix.