Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2965903002: Revert of file_manager: Migrate FILE thread to TaskScheduler (Closed)

Created:
3 years, 5 months ago by Timothy Loh
Modified:
3 years, 5 months ago
Reviewers:
satorux1, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of file_manager: Migrate FILE thread to TaskScheduler (patchset #2 id:60001 of https://codereview.chromium.org/2966713002/ ) Reason for revert: Test FileManagerFileWatcherTest.WatchLocalFile broken on ASAN LSAN and MSAN bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/22079 https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1486 Original issue's description: > file_manager: Migrate FILE thread to TaskScheduler > > BUG=689520 > TEST=new file in Downloads is detected and displayed instantly (file watching is working as before) > > Review-Url: https://codereview.chromium.org/2966713002 > Cr-Commit-Position: refs/heads/master@{#483916} > Committed: https://chromium.googlesource.com/chromium/src/+/28368492d9516e5363810b98a46f587ffb61a270 TBR=fukino@chromium.org,satorux@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=689520 Review-Url: https://codereview.chromium.org/2965903002 Cr-Commit-Position: refs/heads/master@{#483936} Committed: https://chromium.googlesource.com/chromium/src/+/062e1f253f540160c760615b36bdefe9385efe74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
Created Revert of file_manager: Migrate FILE thread to TaskScheduler
3 years, 5 months ago (2017-07-03 03:24:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965903002/1
3 years, 5 months ago (2017-07-03 03:25:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/062e1f253f540160c760615b36bdefe9385efe74
3 years, 5 months ago (2017-07-03 03:58:39 UTC) #6
satorux1
lgtm. thank you for reverting this. let me test with asan locally.
3 years, 5 months ago (2017-07-03 03:59:18 UTC) #7
satorux1
3 years, 5 months ago (2017-07-04 01:13:27 UTC) #8
Message was sent while issue was closed.
FWIW, https://codereview.chromium.org/2970653002/ is a patch for relanding with
a fix.

Powered by Google App Engine
This is Rietveld 408576698