Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2966713002: file_manager: Migrate FILE thread to TaskScheduler (Closed)

Created:
3 years, 5 months ago by satorux1
Modified:
3 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

file_manager: Migrate FILE thread to TaskScheduler BUG=689520 TEST=new file in Downloads is detected and displayed instantly (file watching is working as before) Review-Url: https://codereview.chromium.org/2966713002 Cr-Commit-Position: refs/heads/master@{#483916} Committed: https://chromium.googlesource.com/chromium/src/+/28368492d9516e5363810b98a46f587ffb61a270

Patch Set 1 : file_manager: Migrate FILE thread to TaskScheduler #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
satorux1
3 years, 5 months ago (2017-06-30 07:26:24 UTC) #8
fukino
lgtm
3 years, 5 months ago (2017-06-30 07:40:26 UTC) #9
satorux1
PTAL. Fixed the unit test failure https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_rel_ng%2F459661%2F%2B%2Frecipes%2Fsteps%2Funit_tests__with_patch_%2F0%2Flogs%2FFileManagerFileWatcherTest.WatchLocalFile%2F0 https://codereview.chromium.org/2966713002/diff/60001/chrome/browser/chromeos/file_manager/file_watcher_unittest.cc
3 years, 5 months ago (2017-06-30 08:56:10 UTC) #14
satorux1
PTAL. Fixed the unit test failure https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_rel_ng%2F459661%2F%2B%2Frecipes%2Fsteps%2Funit_tests__with_patch_%2F0%2Flogs%2FFileManagerFileWatcherTest.WatchLocalFile%2F0 https://codereview.chromium.org/2966713002/diff/60001/chrome/browser/chromeos/file_manager/file_watcher_unittest.cc
3 years, 5 months ago (2017-06-30 08:56:12 UTC) #15
fukino
still lgtm.
3 years, 5 months ago (2017-06-30 11:09:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966713002/60001
3 years, 5 months ago (2017-07-01 23:23:07 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/28368492d9516e5363810b98a46f587ffb61a270
3 years, 5 months ago (2017-07-02 00:03:40 UTC) #23
Timothy Loh
3 years, 5 months ago (2017-07-03 03:24:54 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2965903002/ by timloh@chromium.org.

The reason for reverting is: Test FileManagerFileWatcherTest.WatchLocalFile
broken on ASAN LSAN and MSAN bots, e.g.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...
https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MS....

Powered by Google App Engine
This is Rietveld 408576698