Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2965643004: MD Settings: Convert remaining classes to ES6 syntax. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
scottchen
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Convert remaining classes to ES6 syntax. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2965643004 Cr-Commit-Position: refs/heads/master@{#484412} Committed: https://chromium.googlesource.com/chromium/src/+/73cf35c18e4a3f8fb238cdb5f1b7b922e7e41635

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : FIx compilation. #

Patch Set 4 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -194 lines) Patch
M chrome/browser/resources/settings/compiled_resources2.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/direction_delegate.js View 1 2 3 1 chunk +21 lines, -21 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js View 1 2 3 chunks +36 lines, -39 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js View 1 2 1 chunk +44 lines, -50 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 1 2 3 chunks +45 lines, -51 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/cookie_tree_node.js View 1 9 chunks +29 lines, -32 lines 0 comments Download

Messages

Total messages: 29 (21 generated)
dpapad
3 years, 5 months ago (2017-06-30 21:40:03 UTC) #13
scottchen
On 2017/06/30 21:40:03, dpapad wrote: LGTM
3 years, 5 months ago (2017-07-05 18:06:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965643004/60001
3 years, 5 months ago (2017-07-05 18:21:48 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; ...
3 years, 5 months ago (2017-07-05 20:22:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965643004/60001
3 years, 5 months ago (2017-07-05 21:02:08 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; ...
3 years, 5 months ago (2017-07-05 23:02:50 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965643004/60001
3 years, 5 months ago (2017-07-06 00:14:50 UTC) #26
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 00:26:34 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/73cf35c18e4a3f8fb238cdb5f1b7...

Powered by Google App Engine
This is Rietveld 408576698