Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3642)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 2965643004: MD Settings: Convert remaining classes to ES6 syntax. (Closed)
Patch Set: Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
index 2cf10b19aedf561914463a35de5b787f20c2c2e5..f47dbecd3262692298336379bde3c03c349612e9 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
@@ -12,70 +12,56 @@
* Interface for all callbacks to the password API.
* @interface
*/
-function PasswordManager() {}
-
-/** @typedef {chrome.passwordsPrivate.PasswordUiEntry} */
-PasswordManager.PasswordUiEntry;
-
-/** @typedef {chrome.passwordsPrivate.LoginPair} */
-PasswordManager.LoginPair;
-
-/** @typedef {chrome.passwordsPrivate.ExceptionEntry} */
-PasswordManager.ExceptionEntry;
-
-/** @typedef {chrome.passwordsPrivate.PlaintextPasswordEventParameters} */
-PasswordManager.PlaintextPasswordEvent;
-
-PasswordManager.prototype = {
+class PasswordManager {
/**
* Add an observer to the list of saved passwords.
* @param {function(!Array<!PasswordManager.PasswordUiEntry>):void} listener
*/
- addSavedPasswordListChangedListener: assertNotReached,
+ addSavedPasswordListChangedListener(listener) {}
/**
* Remove an observer from the list of saved passwords.
* @param {function(!Array<!PasswordManager.PasswordUiEntry>):void} listener
*/
- removeSavedPasswordListChangedListener: assertNotReached,
+ removeSavedPasswordListChangedListener(listener) {}
/**
* Request the list of saved passwords.
* @param {function(!Array<!PasswordManager.PasswordUiEntry>):void} callback
*/
- getSavedPasswordList: assertNotReached,
+ getSavedPasswordList(callback) {}
/**
* Should remove the saved password and notify that the list has changed.
* @param {!PasswordManager.LoginPair} loginPair The saved password that
* should be removed from the list. No-op if |loginPair| is not found.
*/
- removeSavedPassword: assertNotReached,
+ removeSavedPassword(loginPair) {}
/**
* Add an observer to the list of password exceptions.
* @param {function(!Array<!PasswordManager.ExceptionEntry>):void} listener
*/
- addExceptionListChangedListener: assertNotReached,
+ addExceptionListChangedListener(listener) {}
/**
* Remove an observer from the list of password exceptions.
* @param {function(!Array<!PasswordManager.ExceptionEntry>):void} listener
*/
- removeExceptionListChangedListener: assertNotReached,
+ removeExceptionListChangedListener(listener) {}
/**
* Request the list of password exceptions.
* @param {function(!Array<!PasswordManager.ExceptionEntry>):void} callback
*/
- getExceptionList: assertNotReached,
+ getExceptionList(callback) {}
/**
* Should remove the password exception and notify that the list has changed.
* @param {string} exception The exception that should be removed from the
* list. No-op if |exception| is not in the list.
*/
- removeException: assertNotReached,
+ removeException(exception) {}
/**
* Gets the saved password for a given login pair.
@@ -83,65 +69,71 @@ PasswordManager.prototype = {
* should be retrieved.
* @param {function(!PasswordManager.PlaintextPasswordEvent):void} callback
*/
- getPlaintextPassword: assertNotReached,
-};
+ getPlaintextPassword(loginPair, callback) {}
+}
+
+/** @typedef {chrome.passwordsPrivate.PasswordUiEntry} */
+PasswordManager.PasswordUiEntry;
+
+/** @typedef {chrome.passwordsPrivate.LoginPair} */
+PasswordManager.LoginPair;
+
+/** @typedef {chrome.passwordsPrivate.ExceptionEntry} */
+PasswordManager.ExceptionEntry;
+
+/** @typedef {chrome.passwordsPrivate.PlaintextPasswordEventParameters} */
+PasswordManager.PlaintextPasswordEvent;
/**
* Implementation that accesses the private API.
* @implements {PasswordManager}
- * @constructor
*/
-function PasswordManagerImpl() {}
-cr.addSingletonGetter(PasswordManagerImpl);
-
-PasswordManagerImpl.prototype = {
- __proto__: PasswordManager,
-
+class PasswordManagerImpl {
/** @override */
- addSavedPasswordListChangedListener: function(listener) {
+ addSavedPasswordListChangedListener(listener) {
chrome.passwordsPrivate.onSavedPasswordsListChanged.addListener(listener);
- },
+ }
/** @override */
- removeSavedPasswordListChangedListener: function(listener) {
+ removeSavedPasswordListChangedListener(listener) {
chrome.passwordsPrivate.onSavedPasswordsListChanged.removeListener(
listener);
- },
+ }
/** @override */
- getSavedPasswordList: function(callback) {
+ getSavedPasswordList(callback) {
chrome.passwordsPrivate.getSavedPasswordList(callback);
- },
+ }
/** @override */
- removeSavedPassword: function(loginPair) {
+ removeSavedPassword(loginPair) {
chrome.passwordsPrivate.removeSavedPassword(loginPair);
- },
+ }
/** @override */
- addExceptionListChangedListener: function(listener) {
+ addExceptionListChangedListener(listener) {
chrome.passwordsPrivate.onPasswordExceptionsListChanged.addListener(
listener);
- },
+ }
/** @override */
- removeExceptionListChangedListener: function(listener) {
+ removeExceptionListChangedListener(listener) {
chrome.passwordsPrivate.onPasswordExceptionsListChanged.removeListener(
listener);
- },
+ }
/** @override */
- getExceptionList: function(callback) {
+ getExceptionList(callback) {
chrome.passwordsPrivate.getPasswordExceptionList(callback);
- },
+ }
/** @override */
- removeException: function(exception) {
+ removeException(exception) {
chrome.passwordsPrivate.removePasswordException(exception);
- },
+ }
/** @override */
- getPlaintextPassword: function(loginPair, callback) {
+ getPlaintextPassword(loginPair, callback) {
var listener = function(reply) {
// Only handle the reply for our loginPair request.
if (reply.loginPair.urls.origin == loginPair.urls.origin &&
@@ -153,8 +145,10 @@ PasswordManagerImpl.prototype = {
};
chrome.passwordsPrivate.onPlaintextPasswordRetrieved.addListener(listener);
chrome.passwordsPrivate.requestPlaintextPassword(loginPair);
- },
-};
+ }
+}
+
+cr.addSingletonGetter(PasswordManagerImpl);
/** @typedef {!{model: !{item: !chrome.passwordsPrivate.PasswordUiEntry}}} */
var PasswordUiEntryEvent;

Powered by Google App Engine
This is Rietveld 408576698