Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 5 months ago by Daniel Bratell Modified:
3 years, 5 months ago Reviewers:
fs CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake ElementFactory.cpp.tmpl generate unique names
ElementFactory is used for both SVG and HTML and some names it
exported were the same so in a jumbo build they would collide. By
making the name unique we don't have to exclude the generated files
from jumbo building.
R=fs@opera.com
BUG=
Review-Url: https://codereview.chromium.org/2965343002
Cr-Commit-Position: refs/heads/master@{#484911}
Committed: https://chromium.googlesource.com/chromium/src/+/65232ab5522a55c5643bdd6d1fca47f02df9cb69
Patch Set 1 #
Total comments: 1
Patch Set 2 : Drop an underscore in the generated element factory code. #
Created: 3 years, 5 months ago
Messages
Total messages: 16 (11 generated)
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2965343002/diff/1/third_party/WebKit/Source/b... File third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl (right): https://codereview.chromium.org/2965343002/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl:34: static {{namespace}}Element* {{namespace}}_{{tag|symbol}}Constructor( (I guess that if one were to adhere to coding style, the function name would not have a '_' in it. Getting a nicely cased tag name seems to be more trouble than it's worth though... I don't think something as simple as "{{tag.interface}}Constructor" or so would work?)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bratell@opera.com
The CQ bit was checked by bratell@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com Link to the patchset: https://codereview.chromium.org/2965343002/#ps20001 (title: "Drop an underscore in the generated element factory code.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/07/07 11:01:29, fs wrote: > lgtm > > https://codereview.chromium.org/2965343002/diff/1/third_party/WebKit/Source/b... > File third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl > (right): > > https://codereview.chromium.org/2965343002/diff/1/third_party/WebKit/Source/b... > third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl:34: > static {{namespace}}Element* {{namespace}}_{{tag|symbol}}Constructor( > (I guess that if one were to adhere to coding style, the function name would not > have a '_' in it. Getting a nicely cased tag name seems to be more trouble than > it's worth though... I don't think something as simple as > "{{tag.interface}}Constructor" or so would work?) Dropped the underscore. Tried "|title" but that removed some uppercase letters and tag.interface was not unique.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499428675296440,
"parent_rev": "dd2684796614baa40acbe9d40d96189e842a7a56", "commit_rev":
"65232ab5522a55c5643bdd6d1fca47f02df9cb69"}
Message was sent while issue was closed.
Description was changed from ========== Make ElementFactory.cpp.tmpl generate unique names ElementFactory is used for both SVG and HTML and some names it exported were the same so in a jumbo build they would collide. By making the name unique we don't have to exclude the generated files from jumbo building. R=fs@opera.com BUG= ========== to ========== Make ElementFactory.cpp.tmpl generate unique names ElementFactory is used for both SVG and HTML and some names it exported were the same so in a jumbo build they would collide. By making the name unique we don't have to exclude the generated files from jumbo building. R=fs@opera.com BUG= Review-Url: https://codereview.chromium.org/2965343002 Cr-Commit-Position: refs/heads/master@{#484911} Committed: https://chromium.googlesource.com/chromium/src/+/65232ab5522a55c5643bdd6d1fca... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/65232ab5522a55c5643bdd6d1fca... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
